Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SYN-6083, SYN-6060: Add unlisted perms #3331

Merged
merged 13 commits into from Sep 19, 2023

Conversation

MichaelSquires
Copy link
Contributor

@MichaelSquires MichaelSquires commented Sep 6, 2023

  • Updated cortex permdefs to include unlisted permissions

Resolves SYN-6083 and SYN-6060

@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.08% ⚠️

Comparison is base (c040d5c) 97.24% compared to head (dc42d62) 97.17%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3331      +/-   ##
==========================================
- Coverage   97.24%   97.17%   -0.08%     
==========================================
  Files         228      228              
  Lines       46462    46468       +6     
==========================================
- Hits        45182    45153      -29     
- Misses       1280     1315      +35     
Flag Coverage Δ
linux 97.17% <100.00%> (+<0.01%) ⬆️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
synapse/cortex.py 96.99% <ø> (-0.41%) ⬇️
synapse/lib/stormlib/backup.py 100.00% <100.00%> (ø)
synapse/lib/stormlib/imap.py 100.00% <100.00%> (ø)
synapse/lib/stormlib/log.py 100.00% <100.00%> (ø)
synapse/lib/stormlib/smtp.py 100.00% <100.00%> (ø)
synapse/lib/stormtypes.py 98.75% <100.00%> (+<0.01%) ⬆️

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MichaelSquires MichaelSquires marked this pull request as ready for review September 7, 2023 13:17
@MichaelSquires MichaelSquires changed the title WIP SYN-6083: Add unlisted perms SYN-6083: Add unlisted perms Sep 7, 2023
@MichaelSquires MichaelSquires requested review from invisig0th and vEpiphyte and removed request for invisig0th September 7, 2023 13:18
@vEpiphyte vEpiphyte added this to the v2.14x.x milestone Sep 7, 2023
@vEpiphyte vEpiphyte added enhancement reqChangelog requires changelog labels Sep 7, 2023
@MichaelSquires MichaelSquires changed the title SYN-6083: Add unlisted perms SYN-6083, SYN-6060: Add unlisted perms Sep 8, 2023
@MichaelSquires
Copy link
Contributor Author

MichaelSquires commented Sep 8, 2023

REVIEWERS: I'm not sure all the gates are quite correct. If I wasn't sure (which is most of them), I left it as cortex. Please keep an eye on those.

synapse/cortex.py Outdated Show resolved Hide resolved
synapse/cortex.py Outdated Show resolved Hide resolved
@vEpiphyte vEpiphyte modified the milestones: v2.149.0, v2.150.0 Sep 14, 2023
@MichaelSquires MichaelSquires merged commit a3190e6 into master Sep 19, 2023
5 checks passed
@vEpiphyte vEpiphyte deleted the blackout/SYN-6083/listed-perms branch September 19, 2023 15:34
@vEpiphyte vEpiphyte removed the reqChangelog requires changelog label Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants