Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SYN-6144: stormtypes stor functions are not checked for readonly status #3349

Merged
merged 4 commits into from Sep 21, 2023

Conversation

MichaelSquires
Copy link
Contributor

feat: Check storm runtime for readonly status when setting properties on storm types.

@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.11% ⚠️

Comparison is base (7142d2e) 97.27% compared to head (621a428) 97.16%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3349      +/-   ##
==========================================
- Coverage   97.27%   97.16%   -0.11%     
==========================================
  Files         228      228              
  Lines       46490    46503      +13     
==========================================
- Hits        45221    45186      -35     
- Misses       1269     1317      +48     
Flag Coverage Δ
linux 97.16% <100.00%> (-0.01%) ⬇️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
synapse/lib/stormlib/smtp.py 100.00% <100.00%> (ø)
synapse/lib/stormtypes.py 98.76% <100.00%> (+<0.01%) ⬆️

... and 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MichaelSquires MichaelSquires marked this pull request as ready for review September 21, 2023 17:46
synapse/lib/ast.py Outdated Show resolved Hide resolved
@vEpiphyte vEpiphyte added enhancement reqChangelog requires changelog labels Sep 21, 2023
@vEpiphyte vEpiphyte added this to the v2.150.0 milestone Sep 21, 2023
@MichaelSquires MichaelSquires merged commit 23402e7 into master Sep 21, 2023
5 checks passed
@vEpiphyte vEpiphyte removed the reqChangelog requires changelog label Sep 25, 2023
@vEpiphyte vEpiphyte deleted the blackout/SYN-6144/readonly-props branch December 7, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants