SYN-6144: Make stormfunc(readonly=True) decorator work on storm setitem methods
#3364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3364 +/- ##
==========================================
- Coverage 97.30% 97.20% -0.10%
==========================================
Files 228 228
Lines 46733 46739 +6
==========================================
- Hits 45474 45434 -40
- Misses 1259 1305 +46
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
MichaelSquires
changed the title
stormfunc(readonly=False) decorator work on storm setitem methodsstormfunc(readonly=False) decorator work on storm setitem methods
MichaelSquires
changed the title
stormfunc(readonly=False) decorator work on storm setitem methodsstormfunc(readonly=True) decorator work on storm setitem methods
vEpiphyte
reviewed
Oct 4, 2023
MichaelSquires
force-pushed
the
blackout/readonly-storm-setitem
branch
from
b792460
to
2f1585d
Compare
Merged
invisig0th
approved these changes
Oct 5, 2023
vEpiphyte
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.