Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise an error when attempting to filter by wildcard tag/tagprop with value (SYN-6198) #3373

Merged
merged 37 commits into from Oct 20, 2023

Conversation

Cisphyx
Copy link
Contributor

@Cisphyx Cisphyx commented Oct 6, 2023

No description provided.

@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a10b2cd) 94.16% compared to head (7872387) 97.22%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3373      +/-   ##
==========================================
+ Coverage   94.16%   97.22%   +3.06%     
==========================================
  Files         231      231              
  Lines       46966    46974       +8     
==========================================
+ Hits        44224    45671    +1447     
+ Misses       2742     1303    -1439     
Flag Coverage Δ
linux 97.22% <100.00%> (+<0.01%) ⬆️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
synapse/lib/ast.py 98.99% <100.00%> (+<0.01%) ⬆️
synapse/lib/parser.py 98.53% <ø> (ø)
synapse/lib/storm_format.py 100.00% <ø> (ø)

... and 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

invisig0th
invisig0th previously approved these changes Oct 10, 2023
@Cisphyx Cisphyx changed the title Raise an error when attempting to filter by wildcard tag/tagprop with value (SYN-6198) WIP: Raise an error when attempting to filter by wildcard tag/tagprop with value (SYN-6198) Oct 10, 2023
@Cisphyx Cisphyx changed the title WIP: Raise an error when attempting to filter by wildcard tag/tagprop with value (SYN-6198) Raise an error when attempting to filter by wildcard tag/tagprop with value (SYN-6198) Oct 11, 2023
@vEpiphyte vEpiphyte added bug reqChangelog requires changelog labels Oct 16, 2023
@vEpiphyte vEpiphyte added this to the v2.15x.x milestone Oct 17, 2023
@invisig0th invisig0th merged commit 6794b31 into master Oct 20, 2023
5 checks passed
@invisig0th invisig0th deleted the wildcard-tagfilters branch October 20, 2023 15:08
@vEpiphyte vEpiphyte removed the reqChangelog requires changelog label Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants