New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raise an error when attempting to filter by wildcard tag/tagprop with value (SYN-6198) #3373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t/synapse into wildcard-tagfilters
…t/synapse into wildcard-tagfilters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3373 +/- ##
==========================================
+ Coverage 94.16% 97.22% +3.06%
==========================================
Files 231 231
Lines 46966 46974 +8
==========================================
+ Hits 44224 45671 +1447
+ Misses 2742 1303 -1439
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
invisig0th
previously approved these changes
Oct 10, 2023
Cisphyx
changed the title
Raise an error when attempting to filter by wildcard tag/tagprop with value (SYN-6198)
WIP: Raise an error when attempting to filter by wildcard tag/tagprop with value (SYN-6198)
Oct 10, 2023
…t/synapse into wildcard-tagfilters
Cisphyx
changed the title
WIP: Raise an error when attempting to filter by wildcard tag/tagprop with value (SYN-6198)
Raise an error when attempting to filter by wildcard tag/tagprop with value (SYN-6198)
Oct 11, 2023
This reverts commit 75db95d.
…t/synapse into wildcard-tagfilters
…t/synapse into wildcard-tagfilters
…t/synapse into wildcard-tagfilters
invisig0th
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.