Graph projection speedup SYN-6219, SYN-6467 #3375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3375 +/- ##
==========================================
- Coverage 97.40% 97.31% -0.09%
==========================================
Files 233 233
Lines 48221 48326 +105
==========================================
+ Hits 46968 47027 +59
- Misses 1253 1299 +46
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
invisig0th
requested changes
Oct 10, 2023
rakuy0
changed the title
rakuy0
changed the title
…texproject/synapse into rakuyo/graph-projection-speedup-6219
rakuy0
changed the title
Cisphyx
reviewed
Nov 17, 2023
invisig0th
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A simple
inet:web:postquery that would project 2751 nodes to 8444 nodes originally took about 13.5 minutes on my machine. This patch drops that down to just over 3 seconds while maintaining equivalent edge construction.