SYN-6325: make yaml dep have loud fallback to pure py #3386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugfix: Fix pyyaml fallback detection so it doesn't raise an exception. feat: Update pyyaml fallback warning to be louder (banner style). feat: Update msgpack fallback warning to be louder (banner style).
vEpiphyte
approved these changes
Oct 17, 2023
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3386 +/- ##
==========================================
- Coverage 97.31% 97.22% -0.10%
==========================================
Files 230 230
Lines 47059 47059
==========================================
- Hits 45797 45751 -46
- Misses 1262 1308 +46
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bugfix: Fix pyyaml fallback detection so it doesn't raise an exception.
feat: Update pyyaml fallback warning to be louder (banner style).
feat: Update msgpack fallback warning to be louder (banner style).