SYN-6421: Synapse not modeling private inet:ipv4 with type=private #3410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: Migrate existing `inet:ipv4:type`s from unicast to shared if the form valu is in 100.64.0.0/10.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3410 +/- ##
==========================================
+ Coverage 97.18% 97.28% +0.10%
==========================================
Files 233 233
Lines 47913 47920 +7
==========================================
+ Hits 46562 46621 +59
+ Misses 1351 1299 -52
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Cisphyx
reviewed
Nov 6, 2023
vEpiphyte
reviewed
Nov 6, 2023
…:vertexproject/synapse into blackout/SYN-6421/migrate-inet-ipv4-type
vEpiphyte
approved these changes
Nov 13, 2023
Cisphyx
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Migrate existing
inet:ipv4:types from unicast to shared if the form valu is in 100.64.0.0/10.