Add risk:vuln:id property (SYN-5667) #3447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vEpiphyte
requested review from
invisig0th,
reign-git,
therealsilence,
mbvertex and
mikemoritz
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3447 +/- ##
==========================================
- Coverage 97.58% 97.46% -0.12%
==========================================
Files 231 231
Lines 47549 47549
==========================================
- Hits 46401 46344 -57
- Misses 1148 1205 +57
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mikemoritz
previously approved these changes
Dec 1, 2023
MichaelSquires
previously approved these changes
Dec 4, 2023
invisig0th
approved these changes
Dec 5, 2023
synapse/models/risk.py
Outdated
| @@ -339,6 +339,9 @@ def getModelDefs(self): | |||
| ('timeline:exploited', ('time', {"ismin": True}), { | |||
| 'doc': 'The earliest known time when the vulnerability was exploited in the wild.'}), | |||
|
|
|||
| ('ext:id', ('str', {'strip': True}), { | |||
There was a problem hiding this comment.
Since the whole vuln is being identified via this ID when it comes in from a 3rd party ( and we already have :reporter et al, lets just make this :id 👍
vEpiphyte
dismissed stale reviews from MichaelSquires and mikemoritz
via
0b39a10
invisig0th
requested changes
Dec 5, 2023
invisig0th
approved these changes
Dec 5, 2023
vEpiphyte
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.