Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle invalid CIDR masks in IPv4 norm (SYN-6623) #3459

Merged
merged 5 commits into from Dec 8, 2023
Merged

Conversation

Cisphyx
Copy link
Contributor

@Cisphyx Cisphyx commented Dec 8, 2023

No description provided.

synapse/models/inet.py Outdated Show resolved Hide resolved
synapse/models/inet.py Outdated Show resolved Hide resolved
Copy link
Contributor

@vEpiphyte vEpiphyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the changelog to add an entry for this?

@vEpiphyte vEpiphyte modified the milestones: v2.15x.x, v2.156.0 Dec 8, 2023
@vEpiphyte vEpiphyte added bug model Data model related change labels Dec 8, 2023
@Cisphyx
Copy link
Contributor Author

Cisphyx commented Dec 8, 2023

Can you update the changelog to add an entry for this?

added

Copy link

codecov bot commented Dec 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (aae623a) 97.58% compared to head (17ac20e) 97.47%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3459      +/-   ##
==========================================
- Coverage   97.58%   97.47%   -0.12%     
==========================================
  Files         232      232              
  Lines       47612    47618       +6     
==========================================
- Hits        46464    46415      -49     
- Misses       1148     1203      +55     
Flag Coverage Δ
linux 97.47% <100.00%> (-0.02%) ⬇️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vEpiphyte vEpiphyte merged commit e62efd4 into master Dec 8, 2023
5 checks passed
@vEpiphyte vEpiphyte deleted the ipv4-badcidr branch December 8, 2023 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug model Data model related change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants