Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SYN-6716: it:sec:cpe issues when converting from 2.2->2.3 and 2.3->2.2 #3515

Merged
merged 63 commits into from
May 20, 2024

Conversation

MichaelSquires
Copy link
Contributor

bugfix: Updated CPE code to support better conversions from 2.2->2.3 and vice versa

Copy link

codecov bot commented Jan 24, 2024

Codecov Report

Attention: Patch coverage is 99.23077% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 97.63%. Comparing base (53377ff) to head (23363fa).

Files Patch % Lines
synapse/models/infotech.py 98.86% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3515      +/-   ##
==========================================
+ Coverage   95.90%   97.63%   +1.73%     
==========================================
  Files         237      237              
  Lines       50619    50869     +250     
==========================================
+ Hits        48547    49667    +1120     
+ Misses       2072     1202     -870     
Flag Coverage Δ
linux 97.63% <99.23%> (+9.25%) ⬆️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

synapse/models/infotech.py Outdated Show resolved Hide resolved
synapse/models/infotech.py Outdated Show resolved Hide resolved
synapse/models/infotech.py Outdated Show resolved Hide resolved
invisig0th
invisig0th previously approved these changes May 20, 2024
synapse/models/infotech.py Outdated Show resolved Hide resolved
@MichaelSquires MichaelSquires merged commit 7d592c5 into master May 20, 2024
5 checks passed
@MichaelSquires MichaelSquires deleted the blackout/SYN-6716/cpe-conversions branch May 20, 2024 20:09
@Cisphyx Cisphyx added this to the v2.170.0 milestone May 21, 2024
@Cisphyx Cisphyx removed the reqChangelog requires changelog label May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants