Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clamp certdir names and aha provisioning name values (SYN-6634) #3609

Merged
merged 6 commits into from Mar 11, 2024
Merged

Clamp certdir names and aha provisioning name values (SYN-6634) #3609

merged 6 commits into from Mar 11, 2024

Conversation

vEpiphyte
Copy link
Contributor

  • Ensure that we do not generate CSRs or make certificates with potentially invalid X509 Common Name length strings.
  • Update AHA to prevent creating invalid provisioning requests.

@vEpiphyte
Ensure that we do not generate CSRs or make certificates with potenti…
d940839 
…ally invalid X509 Common Name length strings (SYN-6634)

Update AHA to prevent creating invalid provisioning requests.
@vEpiphyte vEpiphyte added bug reqChangelog requires changelog labels Mar 8, 2024
@vEpiphyte vEpiphyte added this to the v2.16x.x milestone Mar 8, 2024
@codecov Codecov
Copy link

codecov bot commented Mar 8, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.57%. Comparing base (eb88ace) to head (e9f877f).

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3609      +/-   ##
==========================================
- Coverage   97.66%   97.57%   -0.10%     
==========================================
  Files         234      234              
  Lines       49899    49918      +19     
==========================================
- Hits        48736    48706      -30     
- Misses       1163     1212      +49
Flag Coverage Δ
linux 97.57% <100.00%> (+<0.01%) ⬆️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vEpiphyte vEpiphyte removed this from the v2.16x.x milestone Mar 8, 2024
invisig0th
invisig0th requested changes Mar 8, 2024
View reviewed changes
Copy link
Contributor

@invisig0th invisig0th left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doc nits

synapse/lib/aha.py Outdated Show resolved Hide resolved
synapse/lib/aha.py Outdated Show resolved Hide resolved
synapse/lib/certdir.py Outdated Show resolved Hide resolved
synapse/lib/certdir.py Outdated Show resolved Hide resolved
vEpiphyte and others added 2 commits March 8, 2024 13:20
@vEpiphyte @invisig0th
Apply suggestions from code review
2c39480 
Co-authored-by: invisig0th <visi@vertex.link>
@vEpiphyte
Update aha tests
bbdefd2
@vEpiphyte vEpiphyte added this to the v2.16x.x milestone Mar 8, 2024
@vEpiphyte vEpiphyte merged commit 9329818 into master Mar 11, 2024
5 checks passed
@vEpiphyte vEpiphyte deleted the bug_certdir_cname_clamp branch March 11, 2024 16:38
@vEpiphyte vEpiphyte changed the title Clamp certdir cname and aha provisioning name values (SYN-6634) Clamp certdir names and aha provisioning name values (SYN-6634) Mar 13, 2024
@vEpiphyte vEpiphyte removed the reqChangelog requires changelog label Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@invisig0th invisig0th invisig0th approved these changes

@Cisphyx Cisphyx Cisphyx approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v2.165.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vEpiphyte @invisig0th @Cisphyx