SYN-7093: option to prevent deletion of a view #3681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: Added a ``protected`` option for views to prevent merging and deleting. depr: Deprecated the ``nomerge`` option for views. All sets/gets of the ``nomerge`` option will be redirected to the new ``protected`` option instead.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3681 +/- ##
==========================================
- Coverage 97.71% 97.61% -0.10%
==========================================
Files 236 236
Lines 50430 50444 +14
==========================================
- Hits 49277 49242 -35
- Misses 1153 1202 +49
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
MichaelSquires
commented
Apr 12, 2024
MichaelSquires
commented
Apr 12, 2024
|
Here's the regression script: https://github.com/vertexproject/synapse-regression/blob/master/scripts/gen-cortex-storage-v3.py |
Cisphyx
reviewed
Apr 12, 2024
Cisphyx
reviewed
Apr 15, 2024
Cisphyx
previously approved these changes
Apr 16, 2024
invisig0th
requested changes
Apr 16, 2024
Cisphyx
previously approved these changes
Apr 17, 2024
vEpiphyte
reviewed
Apr 18, 2024
vEpiphyte
reviewed
Apr 18, 2024
Cisphyx
previously approved these changes
Apr 18, 2024
…project/synapse into blackout/SYN-7093/protected-views
vEpiphyte
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Added a
protectedoption for views to prevent merging and deleting.feat: Migrate existing
nomergeoptions toprotected.depr: Deprecated the
nomergeoption for views. All sets/gets of thenomergeoption will be redirected to the newprotectedoption instead.