[QPROF] Error on qprof.get_qplan_tree(show_ancestors=False)

[yakirgb]

Hi, on version : '1.0.0-1—01032024-a06640a3cc5a69a826c00f030c49fd89905827b8'
qprof.get_qplan_tree(show_ancestors=False) return error of:

---------------------------------------------------------------------------
UnboundLocalError                         Traceback (most recent call last)
Cell In[24], line 1
----> 1 qprof.get_qplan_tree(show_ancestors=False)

File ~/git/VerticaPy/verticapy/performance/vertica/qprof.py:2316, in QueryProfiler.get_qplan_tree(self, path_id, path_id_info, show_ancestors, metric, pic_path, return_graphviz, **tree_style)
   2314 if return_graphviz:
   2315     return obj.to_graphviz()
-> 2316 return obj.plot_tree(pic_path)

File ~/git/VerticaPy/verticapy/performance/vertica/tree.py:1473, in PerformanceTree.plot_tree(self, pic_path)
   1464 if not conf.get_import_success("graphviz"):
   1465     raise ImportError(
   1466         "The graphviz module doesn't seem to be "
   1467         "installed in your environment.\nTo be "
   (...)
   1471         "the module."
   1472     )
-> 1473 res = graphviz.Source(self.to_graphviz())
   1474 if pic_path:
   1475     res.render(filename=pic_path)

File ~/git/VerticaPy/verticapy/performance/vertica/tree.py:1434, in PerformanceTree.to_graphviz(self)
   1432 else:
   1433     res += "\n"
-> 1434 res += self._gen_labels() + "\n"
   1435 res += self._gen_links() + "\n"
   1436 res += "}"

File ~/git/VerticaPy/verticapy/performance/vertica/tree.py:1232, in PerformanceTree._gen_labels(self)
   1228     html_content = html.escape(html_content).replace("\n", "<br/>")
   1229     res += f'\t{info_bubble} [shape=plaintext, fontcolor="{info_fontcolor}", style="filled", fillcolor="{info_color}", width=0.4, height=0.6, fontsize={info_fontsize}, label=<{html_content}>, URL="#path_id={tree_id}"];\n'
   1230 if (
   1231     self.style["display_etc"]
-> 1232     and tree_id in ancestors
   1233     and not (isinstance(self.path_id, NoneType))
   1234     and nb_children[tree_id] > 1
   1235 ):
   1236     children = self._find_children(tree_id, relationships)
   1237     other_children = []

UnboundLocalError: local variable 'ancestors' referenced before assignment

Thank you,
Yakir Gibraltar
Taboola

[oualib]

Thanks @yakirgb it is a bug, I'll correct it. We are creating robust Unit Test this month. So the object will be stable in 1.0.3.

[yakirgb]

Great, thank you

[oualib]

Bug reported and issue created: #1117. I can close this discussion.

[oualib]

@yakirgb can you please try the latest version and tell me if everything works for you?

[yakirgb]

I can't because i have another error:

from verticapy.performance.vertica import QueryProfiler

qprof = QueryProfiler( 
"SELECT  /*+ LABEL(..) */..."
    target_schema='tests',
    key_id='yakir_8',
    resource_pool='algo_pool',
    overwrite=True
    )

Failing with error :

{
	"name": "QueryError",
	"message": "No transaction with transaction_id=112589991040847037 and statement_id=24 was found in the v_internal.dc_requests_issued table.",
	"stack": "---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
File ~/git/VerticaPy/verticapy/performance/vertica/qprof.py:1354, in QueryProfiler._set_request(self)
   1349 res = _executeSQL(
   1350     query,
   1351     title=\"Getting the corresponding query\",
   1352     method=\"fetchrow\",
   1353 )
-> 1354 self.requests += [res[0]]
   1355 self.request_labels += [res[1]]

TypeError: 'NoneType' object is not subscriptable

During handling of the above exception, another exception occurred:

QueryError                                Traceback (most recent call last)
Cell In[16], line 3
      1 from verticapy.performance.vertica import QueryProfiler
----> 3 qprof = QueryProfiler( 
      4 \"SELECT /*+ LABEL(..) */\"
... (removed the real query)
     39     target_schema='tests',
     40     key_id='yakir_8',
     41     resource_pool='algo_pool',
     42     overwrite=True
     43     )

File ~/git/VerticaPy/verticapy/_utils/_sql/_collect.py:244, in save_verticapy_logs.<locals>.func_prec_save_logs(*args, **kwargs)
    241 json_dict = {**json_dict, **kwargs}
    242 save_to_query_profile(name=name, path=path, json_dict=json_dict)
--> 244 return func(*args, **kwargs)

File ~/git/VerticaPy/verticapy/performance/vertica/qprof.py:976, in QueryProfiler.__init__(self, transactions, key_id, resource_pool, target_schema, overwrite, add_profile, check_tables)
    973 self._create_copy_v_table()
    975 # SETTING THE requests.
--> 976 self._set_request()
    978 # SETTING THE queries durations.
    979 self._set_qduration()

File ~/git/VerticaPy/verticapy/performance/vertica/qprof.py:1357, in QueryProfiler._set_request(self)
   1355         self.request_labels += [res[1]]
   1356     except TypeError:
-> 1357         raise QueryError(
   1358             f\"No transaction with transaction_id={tr_id} \"
   1359             f\"and statement_id={st_id} was found in the \"
   1360             \"v_internal.dc_requests_issued table.\"
   1361         )
   1362 self.request = self.requests[self.transactions_idx]

QueryError: No transaction with transaction_id=112589991040847037 and statement_id=24 was found in the v_internal.dc_requests_issued table."
}

Maybe something changed around request_labels ?

[oualib]

@yakirgb

Ah yes, there was a bug at the beginning not all the transactions were stored, it is the case now. Should I raise a warning instead of an error when a transaction is missing?

Besides, how many transactions are store within your key?

[yakirgb]

Besides, how many transactions are store within your key?
One

I'm doing overwrite=True, i don't understand why that something will be missing.

[yakirgb]

I'll verify later on a new key .

[yakirgb]

I see result with qprof.get_qplan_tree(show_ancestors=False)
But i see same image also with qprof.get_qplan_tree(show_ancestors=True),
So not sure if it's excepted or not .