-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overwrite model parameter #660
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…me parts of classes.
afard
commented
Jul 3, 2023
afard
commented
Jul 3, 2023
Merged
oualib
added
the
Machine Learning - System
Anything related to ML init or system...
label
Jul 5, 2023
oualib
approved these changes
Jul 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main purpose of this PR is to resolve #605. Nevertheless, I made several other improvements as well.
overwrite_model
parameter is moved from the session level config to a parameter of VerticaModel class_model_category
property only inSupervised
andUnsupervised
classes. Then, their subclass will inherit the right one. In case of any exceptions, the property can be overriden.model_name
andoverwrite_model
are common attributes of all models so it makes sense to have them at the base class.AutoDataPrep
class needed its own drop function.overwrite_model
parameter only for a few models. Nevertheless, it covers all if statements that have this parameter.