Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overwrite model parameter #660

Merged
merged 53 commits into from
Jul 5, 2023
Merged

Conversation

afard
Copy link
Collaborator

@afard afard commented Jul 3, 2023

The main purpose of this PR is to resolve #605. Nevertheless, I made several other improvements as well.

  • The overwrite_model parameter is moved from the session level config to a parameter of VerticaModel class
  • It makes more sense to declare the _model_category property only in Supervised and Unsupervised classes. Then, their subclass will inherit the right one. In case of any exceptions, the property can be overriden.
  • The model_name and overwrite_model are common attributes of all models so it makes sense to have them at the base class.
  • The AutoDataPrep class needed its own drop function.
  • Unfortunately, some tests didn't cleanup the database after themselves. The problem doesn't show up in the Github tests because each time a new database is created, but it is very annoying for a developer who runs the tests against the same database. I fixed those. Although there are still leftovers, but they don't cause test failures.
  • I added the tests of the new overwrite_model parameter only for a few models. Nevertheless, it covers all if statements that have this parameter.

afard and others added 30 commits August 5, 2020 16:55
@afard afard requested review from oualib and mail4umar July 3, 2023 05:27
@afard afard self-assigned this Jul 3, 2023
@afard afard mentioned this pull request Jul 4, 2023
@oualib oualib added the Machine Learning - System Anything related to ML init or system... label Jul 5, 2023
@afard afard merged commit 3510be7 into vertica:master Jul 5, 2023
8 checks passed
@afard afard deleted the overwrite_model_parameter branch July 5, 2023 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Machine Learning - System Anything related to ML init or system...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Models should not be overwritten by default
2 participants