Create two MakeFiles

[oualib]

• one for docker users
• one for regular users

@mfelici can you add any useful information here?

@roypaulin can you take the lead on that one?

[roypaulin]

Why do we need 2 Makefiles ? We only need one where we can add any target we want. We use docker only to build dblink, which is convenient, but you can also use this same Makefile to build dblink in a non-docker environment. It is not specific to docker.

[mfelici]

The current situation of vertica/dblink is a little bit messy. We merged the code but not the associated Makefile needed by the code. We are in the middle of the river. Either we cross the river completely or we go back to version 0.2.1. We have two options to fix this situation: OPTION 1: we rename the current vertica/dblink Makefile > Makefile.docker and add a new Makefile copied from mfelici/dblink. One for docker envs, one for docker-free envs. Pros: fast & easy to implement. Cons: we have two Makefiles. OPTION 2: we use a single Makefile but this means: we merge the Makefile compile instructions from mfelici/dblink/Makefile the “default” compile mode (make with no OSTAG and no VERTICA_VERSION) should work out of the box for the standard (non-docker) environment used by 99.99% of the DBLINK users we add crystal clear instructions on how to build DBLINK on both docker/non-docker environment. Current instructions are misleading and incomplete… what is the meaning of OSTAG? Why to use it? How to manage non centos or ubuntu? What VERTICA_VERSION is used for? How to activate DEBUG mode? etc... test the new compile mode Most (all?) of our DBLINK users have issues compiling vertica/dblink in standard (docker-free) envs. My suggestion is to go OPTION 1 immediately (to get out to the river) and then plan & implement & test OPTION 2. P.S. I will be back from my summer holidays next Aug 28th :-) Saluti, Maurizio -- Maurizio Felici | E: ***@***.*** | M: +39 335 5979574

…

On 5 Aug 2023, at 04:57, Roy Paulin ***@***.***> wrote: Why do we need Makefiles ? We only need one where we can add any target we want. We use docker only to build dblink, which is convenient but you can also use this same Makefile to build dblink in a non-docker environment. — Reply to this email directly, view it on GitHub <#21 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AE7X25YW3EEIG4WEIYVIU43XTWZDJANCNFSM6AAAAAA3EKMVOA>. You are receiving this because you were mentioned.

[roypaulin]

I understand, but
1-there is only 1 target in that Makefile that is specific to docker that's why it doesn't make sense for me to create another Makefile. Everything is already there to compile and install dblink on non-docker environment. we can easily improve it and the documentation.

2-vertica/dblink for now is only used by VerticaPyLab, mfelici/dblink is the one customers use (right?), so is there any pressure I am not aware of?

3-OSTAG, VERTICA_VERSION are only for internal use, we can make that clear.

I understand your concern, it is just that renaming it into Makefile.docker makes it look like it is just for docker when that's not the case. It is just that it also offers the possibility to use docker containers for building(which is pretty convenient for internal use, testing and release) but you can still use it on your own vertica environment.

The priority now is releasing 23.3.0 *.so file for dblink and once it's done I am going to work on improving the readme. So that instructions are clear for everyone.