Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor and add config for incremental model #32

Closed
wants to merge 21 commits into from

Conversation

viplazylmht
Copy link

There are some breaking changes I make when working with dbt-vertica on incremental merge stagery:

  • Refactor merge_columns to unique_key.
  • Change MERGE ON logic: use HASH(cols) instead of join DEST.col1 = SRC.col1, DEST.col2 = SRC.col2,...
  • Add additional config: merge_update_columns (list) to be able to update only columns user want.

@viplazylmht
Copy link
Author

Maybe this pull request can close the issue #25

Create table as cannot insert into relation due to missmatch column order between the result of sql
We need another solution to get the response without fetch, or combine
fetching and refactoring somewhere
Feature/add connection_load_balance option to credentials
@andyreagan
Copy link
Contributor

@viplazylmht this is great work. To make this easier to digest, do you think you could split this into three PRs:

  1. Connection load balance changes
  2. Merge updates (here, provide the HASH matching as an option).
  3. Insert+delete updates (for this PR, please include why it's needed).

@andyreagan
Copy link
Contributor

@viplazylmht could you push another PR here? that would trigger the automated tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants