Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scala Native support #17

Closed
david-bouyssie opened this issue Jun 1, 2020 · 4 comments
Closed

Scala Native support #17

david-bouyssie opened this issue Jun 1, 2020 · 4 comments

Comments

@david-bouyssie
Copy link

david-bouyssie commented Jun 1, 2020

https://github.com/takayahilton/sql-formatter was recently updated to support Scala Native
This means that vertical-blank's sql-formatter could easily support Scala Native compilation by depending on https://github.com/takayahilton/sql-formatter.

Other tools using vertical-blank's sql-formatter (such as quill) could thus also be ported to SN without having to change the sql-formatter namespace.
And this would add this dependency only for the SN build.

@vertical-blank
Copy link
Owner

Quill uses this , that uses java or js library according to runtime.
https://github.com/takayahilton/sql-formatter is written in Pure Scala, then Quill should use it.

This library is for use in JVM languages, so Scala project that runs in Scala.js, Scala Native (such as Quill) should not use this.
Therefore, this should not contain other dependencies.

@david-bouyssie
Copy link
Author

Yes my mistake. I created this issue in the wrong repo. I thought it was scala-sql-formatter. Sorry for routing error.

Should I reopen this issue in the scala-sql-formatter repo or do you think it's a dead end, and thus I should open a quill issue instead?

@vertical-blank
Copy link
Owner

Yes, thanks! 😄

@vertical-blank
Copy link
Owner

When the PR for Quill is merged, I will freeze scala-sql-formatter repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants