Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pure Scala version of SQL formatter #1859

Open
david-bouyssie opened this issue May 16, 2020 · 3 comments
Open

Use pure Scala version of SQL formatter #1859

david-bouyssie opened this issue May 16, 2020 · 3 comments

Comments

@david-bouyssie
Copy link

david-bouyssie commented May 16, 2020

The recently added SQL formatter relies on a Java library for the JVM version.
There is however a recent port (https://github.com/takayahilton/sql-formatter) which is written in pure Scala without dependencies. It's not yet published on maven central but I guess this could be asked to the project maintainer.

Thus, I hope you would consider to use this new project in the future (when it is published).
This would open the door for a port of quill on the Scala Native platform.

@getquill/maintainers

@david-bouyssie
Copy link
Author

Work in progress, this PR has been merged: takayahilton/sql-formatter#23

Thanks to this PR takayahilton's sql-formatter now supports Scala Native compilation.

For follow-up, I also opened this issue vertical-blank/sql-formatter#17
Note however that by mistake I opened this new issue in the wrong repo (I was talking about scala-sql-formatter).

@deusaquilus
Copy link
Collaborator

@david-bouyssie @vertical-blank @takayahilton Thank you all for doing some great work! When I originally started looking for a simple JVM-compatible SQL formatter it took me months of searching and I got nowhere. I even got desperate enough to try out Eclipse BIRT's SQL formatter which sorta worked but required a dozen 3rd party dependencies which were over a hundred megs! Now there are multiple great flavors of this library and I really have no idea which to choose. Also, @vertical-blank, I'd like to thank you again for directly supporting Quill by adding Scala JS support. I don't know which library I'm going to choose yet but my heartfelt gratitude goes out to everyone here!

@david-bouyssie
Copy link
Author

@deusaquilus thank you for the short update and for the kind words. On the SN side the version 0.4.0, which was progressing slowly since the release of M2, should soon be out, thanks to the involvement of the Scala Center. Having some parts of quill (at least quill core) on SN would be very nice and would open the door to the development of SN specific (mainly async) drivers on top of quill.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants