Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add field validation for retrieve_list #10

Closed
wants to merge 1 commit into from
Closed

Add field validation for retrieve_list #10

wants to merge 1 commit into from

Conversation

timmartin19
Copy link
Member

  • Added new method _validate_fields to AlchemyManager that raises an
    exception when the fields are not valid
  • retrieve_list validates filters before passing them to sqlalchemy’s
    filter_by
  • Unittests for _validate_fields
  • No relative imports in unittest inits

@timmartin19
Add field validation for retrieve_list
9828649 
* Added new method `_validate_fields` to AlchemyManager that raises an
exception when the fields are not valid
* retrieve_list validates filters before passing them to sqlalchemy’s
`filter_by`
* Unittests for `_validate_fields`
* No relative imports in unittest inits
@timmartin19
Copy link
Member Author

Fixes #10

@coveralls
Copy link

coveralls commented May 13, 2016 •
edited

Coverage Status

Coverage remained the same at 100.0% when pulling 9828649 on filter-fields into 4bcc57e on master.

@timmartin19
Copy link
Member Author

Closing for lack of activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
re-evaluate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timmartin19 @coveralls