forked from prusa3d/Prusa-Firmware
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Old Mesh definitions in... #1
Comments
Thanks, I'll take a look at this. |
vertigo235
added a commit
that referenced
this issue
Apr 8, 2019
vertigo235
added a commit
that referenced
this issue
Apr 8, 2019
Fixed, thanks again! |
vertigo235
added a commit
that referenced
this issue
Apr 8, 2019
vertigo235
added a commit
that referenced
this issue
Apr 17, 2019
vertigo235
added a commit
that referenced
this issue
Apr 24, 2019
vertigo235
added a commit
that referenced
this issue
Apr 25, 2019
vertigo235
added a commit
that referenced
this issue
Apr 29, 2019
vertigo235
added a commit
that referenced
this issue
Apr 30, 2019
vertigo235
added a commit
that referenced
this issue
May 6, 2019
vertigo235
added a commit
that referenced
this issue
May 7, 2019
vertigo235
added a commit
that referenced
this issue
May 10, 2019
vertigo235
added a commit
that referenced
this issue
May 11, 2019
vertigo235
added a commit
that referenced
this issue
May 13, 2019
vertigo235
added a commit
that referenced
this issue
May 30, 2019
vertigo235
added a commit
that referenced
this issue
May 30, 2019
ADD ADDITIONAL CONFIGS ADD .drone.yml Update .gitignore Update MK3 Mesh Definitions Fixes #1 MK3 BMG Z_MAX_POS 210 * Only MK3S FW needs to have 205/204 as MK3 Printer type is set to MK3 for BMG MK3, so the default 210 should work fine. USE GOLD BUILD
vertigo235
added a commit
that referenced
this issue
May 31, 2019
ADD ADDITIONAL CONFIGS ADD .drone.yml Update .gitignore Update MK3 Mesh Definitions Fixes #1 MK3 BMG Z_MAX_POS 210 * Only MK3S FW needs to have 205/204 as MK3 Printer type is set to MK3 for BMG MK3, so the default 210 should work fine. USE GOLD BUILD
vertigo235
added a commit
that referenced
this issue
Jun 12, 2019
ADD ADDITIONAL CONFIGS ADD .drone.yml Update .gitignore Update MK3 Mesh Definitions Fixes #1 MK3 BMG Z_MAX_POS 210 * Only MK3S FW needs to have 205/204 as MK3 Printer type is set to MK3 for BMG MK3, so the default 210 should work fine. USE GOLD BUILD
vertigo235
added a commit
that referenced
this issue
Jun 12, 2019
ADD ADDITIONAL CONFIGS ADD .drone.yml Update .gitignore Update MK3 Mesh Definitions Fixes #1 MK3 BMG Z_MAX_POS 210 * Only MK3S FW needs to have 205/204 as MK3 Printer type is set to MK3 for BMG MK3, so the default 210 should work fine. USE GOLD BUILD
vertigo235
added a commit
that referenced
this issue
Jun 14, 2019
ADD ADDITIONAL CONFIGS ADD .drone.yml Update .gitignore Update MK3 Mesh Definitions Fixes #1 MK3 BMG Z_MAX_POS 210 * Only MK3S FW needs to have 205/204 as MK3 Printer type is set to MK3 for BMG MK3, so the default 210 should work fine. USE GOLD BUILD
vertigo235
added a commit
that referenced
this issue
Jun 30, 2019
ADD ADDITIONAL CONFIGS ADD .drone.yml Update .gitignore Update MK3 Mesh Definitions Fixes #1 MK3 BMG Z_MAX_POS 210 * Only MK3S FW needs to have 205/204 as MK3 Printer type is set to MK3 for BMG MK3, so the default 210 should work fine. USE GOLD BUILD
vertigo235
added a commit
that referenced
this issue
Jun 30, 2019
ADD ADDITIONAL CONFIGS ADD .drone.yml Update .gitignore Update MK3 Mesh Definitions Fixes #1 MK3 BMG Z_MAX_POS 210 * Only MK3S FW needs to have 205/204 as MK3 Printer type is set to MK3 for BMG MK3, so the default 210 should work fine. USE GOLD BUILD
vertigo235
added a commit
that referenced
this issue
Aug 8, 2019
ADD ADDITIONAL CONFIGS ADD .drone.yml Update .gitignore Update MK3 Mesh Definitions Fixes #1 MK3 BMG Z_MAX_POS 210 * Only MK3S FW needs to have 205/204 as MK3 Printer type is set to MK3 for BMG MK3, so the default 210 should work fine. USE GOLD BUILD
vertigo235
added a commit
that referenced
this issue
Aug 12, 2019
ADD ADDITIONAL CONFIGS ADD .drone.yml Update .gitignore Update MK3 Mesh Definitions Fixes #1 MK3 BMG Z_MAX_POS 210 * Only MK3S FW needs to have 205/204 as MK3 Printer type is set to MK3 for BMG MK3, so the default 210 should work fine. USE GOLD BUILD
vertigo235
added a commit
that referenced
this issue
Aug 29, 2019
ADD ADDITIONAL CONFIGS ADD .drone.yml Update .gitignore Update MK3 Mesh Definitions Fixes #1 MK3 BMG Z_MAX_POS 210 * Only MK3S FW needs to have 205/204 as MK3 Printer type is set to MK3 for BMG MK3, so the default 210 should work fine. USE GOLD BUILD
vertigo235
added a commit
that referenced
this issue
Aug 29, 2019
ADD ADDITIONAL CONFIGS ADD .drone.yml Update .gitignore Update MK3 Mesh Definitions Fixes #1 MK3 BMG Z_MAX_POS 210 * Only MK3S FW needs to have 205/204 as MK3 Printer type is set to MK3 for BMG MK3, so the default 210 should work fine. USE GOLD BUILD
vertigo235
added a commit
that referenced
this issue
Sep 9, 2019
ADD ADDITIONAL CONFIGS ADD .drone.yml Update .gitignore Update MK3 Mesh Definitions Fixes #1 MK3 BMG Z_MAX_POS 210 * Only MK3S FW needs to have 205/204 as MK3 Printer type is set to MK3 for BMG MK3, so the default 210 should work fine. USE GOLD BUILD
vertigo235
added a commit
that referenced
this issue
Apr 21, 2020
ADD ADDITIONAL CONFIGS ADD .drone.yml Update .gitignore Update MK3 Mesh Definitions Fixes #1 MK3 BMG Z_MAX_POS 210 * Only MK3S FW needs to have 205/204 as MK3 Printer type is set to MK3 for BMG MK3, so the default 210 should work fine. USE GOLD BUILD
vertigo235
added a commit
that referenced
this issue
Apr 25, 2020
ADD ADDITIONAL CONFIGS ADD .drone.yml Update .gitignore Update MK3 Mesh Definitions Fixes #1 MK3 BMG Z_MAX_POS 210 * Only MK3S FW needs to have 205/204 as MK3 Printer type is set to MK3 for BMG MK3, so the default 210 should work fine. USE GOLD BUILD
vertigo235
added a commit
that referenced
this issue
Apr 28, 2020
ADD ADDITIONAL CONFIGS ADD .drone.yml Update .gitignore Update MK3 Mesh Definitions Fixes #1 MK3 BMG Z_MAX_POS 210 * Only MK3S FW needs to have 205/204 as MK3 Printer type is set to MK3 for BMG MK3, so the default 210 should work fine. USE GOLD BUILD
vertigo235
added a commit
that referenced
this issue
May 6, 2020
ADD ADDITIONAL CONFIGS ADD .drone.yml Update .gitignore Update MK3 Mesh Definitions Fixes #1 MK3 BMG Z_MAX_POS 210 * Only MK3S FW needs to have 205/204 as MK3 Printer type is set to MK3 for BMG MK3, so the default 210 should work fine. USE GOLD BUILD
vertigo235
added a commit
that referenced
this issue
May 12, 2020
ADD ADDITIONAL CONFIGS ADD .drone.yml Update .gitignore Update MK3 Mesh Definitions Fixes #1 MK3 BMG Z_MAX_POS 210 * Only MK3S FW needs to have 205/204 as MK3 Printer type is set to MK3 for BMG MK3, so the default 210 should work fine. USE GOLD BUILD
vertigo235
added a commit
that referenced
this issue
May 15, 2020
ADD ADDITIONAL CONFIGS ADD .drone.yml Update .gitignore Update MK3 Mesh Definitions Fixes #1 MK3 BMG Z_MAX_POS 210 * Only MK3S FW needs to have 205/204 as MK3 Printer type is set to MK3 for BMG MK3, so the default 210 should work fine. USE GOLD BUILD
vertigo235
added a commit
that referenced
this issue
May 18, 2020
ADD ADDITIONAL CONFIGS ADD .drone.yml Update .gitignore Update MK3 Mesh Definitions Fixes #1 MK3 BMG Z_MAX_POS 210 * Only MK3S FW needs to have 205/204 as MK3 Printer type is set to MK3 for BMG MK3, so the default 210 should work fine. USE GOLD BUILD
vertigo235
added a commit
that referenced
this issue
May 28, 2020
ADD ADDITIONAL CONFIGS ADD .drone.yml Update .gitignore Update MK3 Mesh Definitions Fixes #1 MK3 BMG Z_MAX_POS 210 * Only MK3S FW needs to have 205/204 as MK3 Printer type is set to MK3 for BMG MK3, so the default 210 should work fine. USE GOLD BUILD
vertigo235
added a commit
that referenced
this issue
Jun 3, 2020
ADD ADDITIONAL CONFIGS ADD .drone.yml Update .gitignore Update MK3 Mesh Definitions Fixes #1 MK3 BMG Z_MAX_POS 210 * Only MK3S FW needs to have 205/204 as MK3 Printer type is set to MK3 for BMG MK3, so the default 210 should work fine. USE GOLD BUILD
vertigo235
added a commit
that referenced
this issue
Jun 10, 2020
ADD ADDITIONAL CONFIGS ADD .drone.yml Update .gitignore Update MK3 Mesh Definitions Fixes #1 MK3 BMG Z_MAX_POS 210 * Only MK3S FW needs to have 205/204 as MK3 Printer type is set to MK3 for BMG MK3, so the default 210 should work fine. USE GOLD BUILD
vertigo235
added a commit
that referenced
this issue
Jun 20, 2020
ADD ADDITIONAL CONFIGS ADD .drone.yml Update .gitignore Update MK3 Mesh Definitions Fixes #1 MK3 BMG Z_MAX_POS 210 * Only MK3S FW needs to have 205/204 as MK3 Printer type is set to MK3 for BMG MK3, so the default 210 should work fine. USE GOLD BUILD
vertigo235
added a commit
that referenced
this issue
Jun 21, 2020
ADD ADDITIONAL CONFIGS ADD .drone.yml Update .gitignore Update MK3 Mesh Definitions Fixes #1 MK3 BMG Z_MAX_POS 210 * Only MK3S FW needs to have 205/204 as MK3 Printer type is set to MK3 for BMG MK3, so the default 210 should work fine. USE GOLD BUILD
vertigo235
added a commit
that referenced
this issue
Jun 21, 2020
ADD ADDITIONAL CONFIGS ADD .drone.yml Update .gitignore Update MK3 Mesh Definitions Fixes #1 MK3 BMG Z_MAX_POS 210 * Only MK3S FW needs to have 205/204 as MK3 Printer type is set to MK3 for BMG MK3, so the default 210 should work fine. USE GOLD BUILD
vertigo235
added a commit
that referenced
this issue
Jun 23, 2020
ADD ADDITIONAL CONFIGS ADD .drone.yml Update .gitignore Update MK3 Mesh Definitions Fixes #1 MK3 BMG Z_MAX_POS 210 * Only MK3S FW needs to have 205/204 as MK3 Printer type is set to MK3 for BMG MK3, so the default 210 should work fine. USE GOLD BUILD
vertigo235
added a commit
that referenced
this issue
Jun 25, 2020
Create Drone Build ADD ADDITIONAL CONFIGS ADD .drone.yml Update .gitignore Update MK3 Mesh Definitions Fixes #1 MK3 BMG Z_MAX_POS 210 * Only MK3S FW needs to have 205/204 as MK3 Printer type is set to MK3 for BMG MK3, so the default 210 should work fine. USE GOLD BUILD Add Skelestruder Build * Uses the python script from https://github.com/nato2k/Skelestruder_Firmware_Patch Update Steps* Remove the test builds from test and just use the PF-build.sh builds instead (Travis job will still run the other builds) Update Variants Skelestruder Build is for 16 Microsteps Add Bear Gearbox 16MS Variant Changes for Gearbox 16 MS Rename to match convention Update Display Name for Gearbox Variant Update Gearbox Configs Use Define for XYZ Calibration Thanks for the wonderful work and making all the variants explicit, this was really helpful! I had a concern with respect to Bondtech BMG and MK3S firmware, and the way Prusa fixed it and how for a bondtech it reduces Z_MAX_POS. Basically, instead of increasing Z_MAX_POS for the MK3S by 6, Prusa decided to leave it as is, and... to extend the travel down when calibrating XYZ by 7. As a result, Prusa's "S" firmware does not work for a taller extruder, like the Bondtech for the "S" variant. What Prusa _should_ have done is INCREASE Z_MAX_POS in their variant by 6 for the "S" extruder and leave the "travel down mechanism"for XYZ calibration as it was. Then we could have kept the Z_MAX_POS to 210 for BMG variants and all would be fine. Now, we have a smaller Z_MAX_POS as necessary, if we want to use the "S" firmware. I implemented it - in my opinion - correctly in the branch, by introducing a new variable to work exactly "where it hurts": during Z calibration: see the pull request. In particular, look at Marlin_main.cpp at line 2121 and the "S" variants, that now set the offset correctly (basically to 9 for "S" extruders and 2 elsewhere..) There is also an unclear thing in the Prusa file, in that they test for "MK3", (the alternative being MK3S), but the should have tested on MK3S and MK2.5S and then have all the others as alternative. My variant puts that test "out of order" and sets the desired XYZ calibration travel to the correct value for each extruder. I issued a pull request to Prusa, but have little hope that they would do it correctly, or even better: set Z_MAX_POS for their "S" variants to 217 and leave the algorithm in Marlin_main.cpp like how it was before, then Prusa owners would "enjoy" higher Z.... To summarize: the change is easy: only one file (marlin_main.cpp) and a new constant in each variant. I just went through the many variant files to set it. I hope it is clear (and I believe it to be cleaner). Added #define for Z_MAX_POS_XYZ_CALIBRATION_CORRECTION in order to configure XYZ calibration for a Bondtech and Bear extruder for the MK3S. Gearbox: Use Z_MAX_POS_XYZ_CALIBRATION_CORRECTION Add MMU2S More Load Patch MMU2S More Load Patch Update Variants Add 32 and 8 Microstepping Skelestruder Builds Rename MK25S-BMG Variants Remove all geared 1/32 micostep options / Add 1/8 microstep for BMG Add Watchdog Support Set FW_COMMIT_NR to epoch time * Creates unique FW file names Remove git reset to retain epoch build number for skele Add 1_75mm_MK3S-320Z-BMG-16-EINSy10a-E3Dv6full.h Update Variants now that M350 is supported * Microstepping can now be set via M350 for EINSY Fix Skele Patch Fix MK2S BEAR XYZ CAL Use fw-build image for correct depedencies Readd 320 Z Build Fix M600 / Compile Issue for Taller Frame (Zaribo etc) * Update fsensor.cpp M600 Z_MAX_POS * Update Marlin_main.cpp M600 Z_MAX_POS Add create_variants.sh script Creates scripts based on base script so that updates from Prusa can be more easily merged into variant configs. Update Variants * Remove Gearbox * Remove load more patch * Rename BMG to Bondtech (Bondtech Prusa Extruder) * Add 320Z Variants * Add MK25 Variants Update Variants New Build Script Output Folder Update Variants (ASA Pretemp) Add MK3S Silver PSU Variants Update drone to include silver PSU builds Add transfer.sh step to build Add Slice High Temp Thermistor Update create_variant.sh script * Create Slice Thermistor Variants Add Bondtech Slice Thermistor Variants Rename Slice Thermistor Variants Fix MK2S SliceHT Parallel Steps / File.io Slice: Change Min/Max Temp Update Variants Fix Slice Variant Script Fix Drone Workspace Update Variants Enable Cutter Update Variants Update Variants Update Variants * ADD Silver PSU for Bondtech-16-SliceHT Add MK3S Bear SilverPSU Variant without LA Compat Added support for WEH002004 OLED display * Source Zaribo FW Fork (3d-gussner) OLED Variants * Enable OLED in all Variants Bondtech MMU Adjustments Update Variants * Bondtech Updates Update Variants - PC Blend Preheat
vertigo235
added a commit
that referenced
this issue
Aug 7, 2020
ADD ADDITIONAL CONFIGS ADD .drone.yml Update .gitignore Update MK3 Mesh Definitions Fixes #1 MK3 BMG Z_MAX_POS 210 * Only MK3S FW needs to have 205/204 as MK3 Printer type is set to MK3 for BMG MK3, so the default 210 should work fine. USE GOLD BUILD
vertigo235
added a commit
that referenced
this issue
Aug 25, 2020
ADD ADDITIONAL CONFIGS ADD .drone.yml Update .gitignore Update MK3 Mesh Definitions Fixes #1 MK3 BMG Z_MAX_POS 210 * Only MK3S FW needs to have 205/204 as MK3 Printer type is set to MK3 for BMG MK3, so the default 210 should work fine. USE GOLD BUILD
vertigo235
added a commit
that referenced
this issue
Sep 22, 2020
ADD ADDITIONAL CONFIGS ADD .drone.yml Update .gitignore Update MK3 Mesh Definitions Fixes #1 MK3 BMG Z_MAX_POS 210 * Only MK3S FW needs to have 205/204 as MK3 Printer type is set to MK3 for BMG MK3, so the default 210 should work fine. USE GOLD BUILD
vertigo235
added a commit
that referenced
this issue
Oct 11, 2020
ADD ADDITIONAL CONFIGS ADD .drone.yml Update .gitignore Update MK3 Mesh Definitions Fixes #1 MK3 BMG Z_MAX_POS 210 * Only MK3S FW needs to have 205/204 as MK3 Printer type is set to MK3 for BMG MK3, so the default 210 should work fine. USE GOLD BUILD
vertigo235
added a commit
that referenced
this issue
Nov 14, 2020
ADD ADDITIONAL CONFIGS ADD .drone.yml Update .gitignore Update MK3 Mesh Definitions Fixes #1 MK3 BMG Z_MAX_POS 210 * Only MK3S FW needs to have 205/204 as MK3 Printer type is set to MK3 for BMG MK3, so the default 210 should work fine. USE GOLD BUILD
vertigo235
added a commit
that referenced
this issue
Dec 31, 2020
ADD ADDITIONAL CONFIGS ADD .drone.yml Update .gitignore Update MK3 Mesh Definitions Fixes #1 MK3 BMG Z_MAX_POS 210 * Only MK3S FW needs to have 205/204 as MK3 Printer type is set to MK3 for BMG MK3, so the default 210 should work fine. USE GOLD BUILD
vertigo235
added a commit
that referenced
this issue
Feb 27, 2021
ADD ADDITIONAL CONFIGS ADD .drone.yml Update .gitignore Update MK3 Mesh Definitions Fixes #1 MK3 BMG Z_MAX_POS 210 * Only MK3S FW needs to have 205/204 as MK3 Printer type is set to MK3 for BMG MK3, so the default 210 should work fine. USE GOLD BUILD
vertigo235
added a commit
that referenced
this issue
Feb 27, 2021
ADD ADDITIONAL CONFIGS ADD .drone.yml Update .gitignore Update MK3 Mesh Definitions Fixes #1 MK3 BMG Z_MAX_POS 210 * Only MK3S FW needs to have 205/204 as MK3 Printer type is set to MK3 for BMG MK3, so the default 210 should work fine. USE GOLD BUILD
vertigo235
added a commit
that referenced
this issue
Feb 27, 2021
ADD ADDITIONAL CONFIGS ADD .drone.yml Update .gitignore Update MK3 Mesh Definitions Fixes #1 MK3 BMG Z_MAX_POS 210 * Only MK3S FW needs to have 205/204 as MK3 Printer type is set to MK3 for BMG MK3, so the default 210 should work fine. USE GOLD BUILD
vertigo235
added a commit
that referenced
this issue
Mar 21, 2021
ADD ADDITIONAL CONFIGS ADD .drone.yml Update .gitignore Update MK3 Mesh Definitions Fixes #1 MK3 BMG Z_MAX_POS 210 * Only MK3S FW needs to have 205/204 as MK3 Printer type is set to MK3 for BMG MK3, so the default 210 should work fine. USE GOLD BUILD
vertigo235
added a commit
that referenced
this issue
Apr 2, 2021
ADD ADDITIONAL CONFIGS ADD .drone.yml Update .gitignore Update MK3 Mesh Definitions Fixes #1 MK3 BMG Z_MAX_POS 210 * Only MK3S FW needs to have 205/204 as MK3 Printer type is set to MK3 for BMG MK3, so the default 210 should work fine. USE GOLD BUILD
vertigo235
added a commit
that referenced
this issue
May 8, 2021
ADD ADDITIONAL CONFIGS ADD .drone.yml Update .gitignore Update MK3 Mesh Definitions Fixes #1 MK3 BMG Z_MAX_POS 210 * Only MK3S FW needs to have 205/204 as MK3 Printer type is set to MK3 for BMG MK3, so the default 210 should work fine. USE GOLD BUILD
vertigo235
added a commit
that referenced
this issue
Oct 4, 2021
ADD ADDITIONAL CONFIGS ADD .drone.yml Update .gitignore Update MK3 Mesh Definitions Fixes #1 MK3 BMG Z_MAX_POS 210 * Only MK3S FW needs to have 205/204 as MK3 Printer type is set to MK3 for BMG MK3, so the default 210 should work fine. USE GOLD BUILD
vertigo235
added a commit
that referenced
this issue
Jan 21, 2022
ADD ADDITIONAL CONFIGS ADD .drone.yml Update .gitignore Update MK3 Mesh Definitions Fixes #1 MK3 BMG Z_MAX_POS 210 * Only MK3S FW needs to have 205/204 as MK3 Printer type is set to MK3 for BMG MK3, so the default 210 should work fine. USE GOLD BUILD
vertigo235
added a commit
that referenced
this issue
Jan 21, 2022
ADD ADDITIONAL CONFIGS ADD .drone.yml Update .gitignore Update MK3 Mesh Definitions Fixes #1 MK3 BMG Z_MAX_POS 210 * Only MK3S FW needs to have 205/204 as MK3 Printer type is set to MK3 for BMG MK3, so the default 210 should work fine. USE GOLD BUILD
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
...
The text was updated successfully, but these errors were encountered: