We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Although the build succeeds, the compiler raises warnings. I'll send a PR soon.
nicklarsen@fourier:objconv$ g++ -o objconv -O2 src/*.cpp src/disasm1.cpp:1135:36: warning: '&&' within '||' [-Wlogical-op-parentheses] if (s.AddressFieldSize && (s.MFlags & 0x100) || s.ImmediateFieldSize) { ~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~ ~~ src/disasm1.cpp:1135:36: note: place parentheses around the '&&' expression to silence this warning if (s.AddressFieldSize && (s.MFlags & 0x100) || s.ImmediateFieldSize) { ^ ( ) src/disasm1.cpp:1169:42: warning: '&&' within '||' [-Wlogical-op-parentheses] || (TargetType+1 & 0xFE) == 0x0C && (Symbols[SymNewI].Type & 0xFF) > 0x0C) { ~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ src/disasm1.cpp:1169:42: note: place parentheses around the '&&' expression to silence this warning || (TargetType+1 & 0xFE) == 0x0C && (Symbols[SymNewI].Type & 0xFF) > 0x0C) { ^ ( ) src/disasm1.cpp:2284:29: warning: '&&' within '||' [-Wlogical-op-parentheses] if ((s.Errors & 0x4000) && ((s.Warnings1 & 0x10000000) || CountErrors > 1) ~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ src/disasm1.cpp:2284:29: note: place parentheses around the '&&' expression to silence this warning if ((s.Errors & 0x4000) && ((s.Warnings1 & 0x10000000) || CountErrors > 1) ^ ( ) 3 warnings generated.
The text was updated successfully, but these errors were encountered:
Fixed vertis#6 - missing parentheses
d04c4b9
Pinging @vertis
Sorry, something went wrong.
No branches or pull requests
Although the build succeeds, the compiler raises warnings. I'll send a PR soon.
The text was updated successfully, but these errors were encountered: