Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support void type of function #493

Merged
merged 7 commits into from
Feb 8, 2024
Merged

Conversation

YSawc
Copy link
Contributor

@YSawc YSawc commented Feb 6, 2024

modify support void type of function. I noticed that only reference assignment function that does not returns value is not supported yet.

@dalance
Copy link
Collaborator

dalance commented Feb 7, 2024

Thank you for your contribution.
I think there is another solution to support void function.

// void return type support
function Func () -> void {
}

// omittable return type
function Func () {
}

How do you think?

@YSawc
Copy link
Contributor Author

YSawc commented Feb 7, 2024

It sounds good! May i change logic to apply your suggestion?

@YSawc
Copy link
Contributor Author

YSawc commented Feb 7, 2024

@dalance
194a685
I changed to apply omit return type. Please confirm changed logic.

Copy link
Collaborator

@dalance dalance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
I've added a comment about alignment of emitter.
Could you check it?

crates/emitter/src/aligner.rs Outdated Show resolved Hide resolved
crates/emitter/src/aligner.rs Outdated Show resolved Hide resolved
YSawc and others added 2 commits February 8, 2024 13:19
Co-authored-by: dalance <dalance@gmail.com>
Co-authored-by: dalance <dalance@gmail.com>
@YSawc
Copy link
Contributor Author

YSawc commented Feb 8, 2024

Thanks your feedback! I applied each suggestions.

@dalance
Copy link
Collaborator

dalance commented Feb 8, 2024

Thanks!!
I'll merge this PR.

@dalance dalance added the enhancement New feature or request label Feb 8, 2024
@dalance dalance merged commit 53c9828 into veryl-lang:master Feb 8, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants