fixes inverted order of member list for refl::util::detail::filter(..) #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reasons: `static constexpr std::size_t sigStackSize = 32768 >= MINSIGSTKSZ ? 32768 : MINSIGSTKSZ;` For modern Linux systems the underlying MINSIGSTKSZ became a non-`constexpr` system call ‘long int sysconf(int)’ N.B. this is probably one of the last single-header catch2 distributions as they seem to move for v3.x.y to a [multi-header statically compiled library](https://github.com/catchorg/catch2/releases#repo-content-pjax-container) distribution model.
apparently the 'append_t' needed to change to 'prepend_t' introduced in #a5819553 possible fix for issue veselink1#64
veselink1
approved these changes
Jan 8, 2022
| constexpr type_list<int, float> flt = util::filter(type_list<int, float>{}, [](auto ) { return true; }); | ||
| REQUIRE( flt.size == 2 ); | ||
| constexpr int first = find_first(type_list<int, float>{}, [](auto ) { return true; }); | ||
| REQUIRE( std::is_same_v<decltype(first), const int> ); |
There was a problem hiding this comment.
The funny thing with most of the refl-cpp tests is that they wouldn't even compile if the types were not correct. This is the case here as well (first is explicitly typed as int). Nevertheless, I use REQUIRE everywhere too.
There was a problem hiding this comment.
Was thinking of static_assert as well but since the other test use REQUIRE I went down that same route.
Thanks for merging!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seemed to be the least invasive fix for the issue.
N.B. needed to bump the catch unit-test library version to be able to build on a more Linux OS