Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove go panic information in nebula-console #110

Closed
awsl-dbq opened this issue Jan 28, 2022 · 3 comments
Closed

remove go panic information in nebula-console #110

awsl-dbq opened this issue Jan 28, 2022 · 3 comments

Comments

@awsl-dbq
Copy link

Hello,
If I input something wrong, it's better for nebula-console just print the error information instead of panic messages.

/ # nebula-console -user forerror
2022/01/28 09:34:11 Error: argument port is missed!
panic: Error: argument port is missed!

goroutine 1 [running]:
log.Panicf(0x7b5a5f, 0x1f, 0x0, 0x0, 0x0)
	/usr/local/go/src/log/log.go:345 +0xc0
main.validateFlags()
	/usr/src/main.go:369 +0x1a5
main.main()
	/usr/src/main.go:404 +0xbb

a simple one as expected :

# nebula-console -user forerror
2022/01/28 09:34:11 Error: argument port is missed!
@wey-gu
Copy link
Contributor

wey-gu commented Jan 29, 2022

good point, issue created: vesoft-inc/nebula-console#162

For console, this is an example fyi:

nebula-console  -addr 192.168.100.128 -port 9669 -user root -p nebula

@awsl-dbq
Copy link
Author

okay, thank you

@wey-gu
Copy link
Contributor

wey-gu commented Mar 15, 2024

@awsl-dbq now the master of the console is way better in such cases :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants