Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mistake check of yield expression in yield sentence. #2646

Closed
Shylock-Hg opened this issue Jun 23, 2021 · 3 comments
Closed

Mistake check of yield expression in yield sentence. #2646

Shylock-Hg opened this issue Jun 23, 2021 · 3 comments
Assignees
Labels
incompatible PR: incompatible with the recently released version priority/hi-pri Priority: high type/bug Type: something is unexpected
Milestone

Comments

@Shylock-Hg
Copy link
Contributor

a = go from 'Tim Duncan' over *; yield $a;
a = go from 'Tim Duncan' over *; yield $a[1][1];

In yield validator, mistake check the evaluable of expression of yield column.

@Shylock-Hg Shylock-Hg self-assigned this Jun 25, 2021
@Shylock-Hg
Copy link
Contributor Author

@CPWstatic @yixinglu @laura-ding @Aiee @jievince vesoft-inc/nebula-graph#764 will analysis the lifetime of variable by the inputVars of plan node, so we must set the all variable used by one plan node to its inputVars, Or

  1. Maybe get empty result for the variable generated by plan node output;
  2. Variable keep alive until the query finish for the variable manually generated when validating/planning.

@Shylock-Hg
Copy link
Contributor Author

This only crash in debug mode, get null in release.

@CPWstatic CPWstatic transferred this issue from vesoft-inc/nebula-graph Aug 27, 2021
@CPWstatic CPWstatic added type/bug Type: something is unexpected priority/hi-pri Priority: high labels Aug 27, 2021
@CPWstatic CPWstatic added this to the v2.6.0 milestone Aug 30, 2021
@CPWstatic CPWstatic assigned jievince and unassigned Shylock-Hg Aug 30, 2021
@Sophie-Xie Sophie-Xie assigned Shylock-Hg and unassigned jievince Aug 31, 2021
@Sophie-Xie Sophie-Xie added the incompatible PR: incompatible with the recently released version label Sep 28, 2021
@Sophie-Xie Sophie-Xie modified the milestones: v2.6.0, v3.0.0 Sep 28, 2021
@Shylock-Hg
Copy link
Contributor Author

Solved in #3211

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
incompatible PR: incompatible with the recently released version priority/hi-pri Priority: high type/bug Type: something is unexpected
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants