Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dashboard nebula-httpd show null #38

Closed
Reid00 opened this issue Sep 1, 2021 · 4 comments
Closed

dashboard nebula-httpd show null #38

Reid00 opened this issue Sep 1, 2021 · 4 comments
Labels
enhancement New feature or request

Comments

@Reid00
Copy link
Contributor

Reid00 commented Sep 1, 2021

Since dashboard nebula-httpd port 8090 show null is confused, i want to submit pull request change the response with below:
{
"code": 0,
"data": "Run Successfully!",
"message": "Welcome Nebula-Http-GateWay!"
}
Is this ok?

@wey-gu
Copy link

wey-gu commented Sep 1, 2021

@Reid00 Thanks so much!

@hetao92 what do you think? maybe a discussion on the wording first here then @Reid00 could go ahead on the PR ;-).

@wey-gu
Copy link

wey-gu commented Sep 2, 2021

@Reid00 , just talked with @hetao92 , it's great to have your PR on this, could you kindly help with it?
Thanks!!!

@Reid00
Copy link
Contributor Author

Reid00 commented Sep 2, 2021

@wey-gu have submitted PR, please review it.

@hetao92
Copy link
Contributor

hetao92 commented Oct 27, 2021

added

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants