Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a more clarify phrasing to state out the assigned value gp2 on k8s property storageClassName #169

Closed
nekomeowww opened this issue Dec 18, 2022 · 4 comments

Comments

@nekomeowww
Copy link

nekomeowww commented Dec 18, 2022

Introduction

When I trying to deploy nebula-clutser with helm, the comment for storageClassName states:

export STORAGE_CLASS_NAME=gp2 # the storage class for the nebula cluster

I think such phrasing mislead me. While such phrasing may be familiar with these operators and developers that are using or have used AWS EBS on or not on K8S, however, I originally thought gp2 might be some special storgae value that nebula graph has provided for K8S container runtime with the same property name on it when in cluster deployment (since the phrasing says for nebula clutser), until I found out this is just the StorageClass type value of K8S itself.

Contents

We may be able to state out that such value for storageClassName will be applied to K8S itself and operators should pick one of the desired and possible value for this property on the demand of themselves instead of just pointing out it is for the nebula cluster .

Or I suggest to set the default value to local on storageClassName in values.yaml, and state out the preferences may be made by operators and developers in comments.

Related work

None

@nekomeowww nekomeowww changed the title Use a more clarify phrasing to state out the assigned value gp2 on property storageClassName Use a more clarify phrasing to state out the assigned value gp2 on k8s property storageClassName Dec 18, 2022
@MegaByte875
Copy link
Contributor

@nekomeowww Thanks for your suggestion, actuallay gp2 is used for eks that runs on aws, if you test nebula in a local development environment, local is a right configuration. I will update the value to local.

@nekomeowww
Copy link
Author

Thank you for you reply. I used local and it deployed successfully afterwards.

@QingZ11
Copy link
Contributor

QingZ11 commented Dec 26, 2022

Thank you for you reply. I used local and it deployed successfully afterwards.

If your problem is solved, would you like to close the issue? Thanks a lot for your contribution.

@nekomeowww
Copy link
Author

If your problem is solved, would you like to close the issue? Thanks a lot for your contribution.

Closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants