Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] run test ci when upstream repo update #115

Closed
yihong0618 opened this issue Jun 17, 2021 · 2 comments
Closed

[feat] run test ci when upstream repo update #115

yihong0618 opened this issue Jun 17, 2021 · 2 comments

Comments

@yihong0618
Copy link
Contributor

image

Because this CI depends on the upstream repo.
So CI may failed when the upstream repo changed.

we can add some curl command when then upstream update trigger this CI

something like

curl -H "Content-Type:application/json" -X POST -d '{"inputs": {}, "ref":"main"}' https://api.github.com/repos/yihong0618/2021/actions/workflows/${id}/dispatches -H "Authorization: token ${{ secrets.GITHUB_TOKEN }}"

The api workflow doc here

@wey-gu
Copy link
Contributor

wey-gu commented Jun 17, 2021

Thank you @yihong0618!

It's indeed a decent approach to make event-driven tests triggered by upstream code change when there is such dependency on the master to address i.e. thrift change caused failures.

@laura-ding what do you think?

@laura-ding
Copy link
Contributor

@yihong0618 Thanks for your advice. I think adding a schedule task to run CI is ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants