Add ConcurrentLRUCache #1268
Add ConcurrentLRUCache #1268
Conversation
dangleptr
requested review from
dutor,
bright-starry-sky,
CPWstatic,
critical27,
darionyaphet,
laura-ding,
liuyu85cn,
monadbobo and
sherman-the-tank
| std::lock_guard<std::mutex> guard(lock_); | ||
| auto v = lru_->get(key); | ||
| if (v == boost::none) { | ||
| return Status::Error(); | ||
| } | ||
| return std::move(v).value(); |
There was a problem hiding this comment.
Ask a question，do we need insert it to cache immediate If this key is not exist in cache ?
There was a problem hiding this comment.
Agreed, maybe we need another method putIfAbsent
|
Unit testing passed. |
|
LGTM |
|
Jenkins go |
|
Unit testing passed. |
| void clear() { | ||
| for (auto i = 0; i < bucketsNum_; i++) { | ||
| buckets_[i].clear(); | ||
| } |
There was a problem hiding this comment.
is it need buckets_.clear() at here?
There was a problem hiding this comment.
When we call clear, what we want is to clear the content in cache, not destroy the buckets.
| @@ -0,0 +1,79 @@ | |||
| /* Copyright (c) 2018 vesoft inc. All rights reserved. | |||
| std::lock_guard<std::mutex> guard(lock_); | ||
| auto v = lru_->get(key); | ||
| if (v == boost::none) { | ||
| return Status::Error(); |
There was a problem hiding this comment.
Status::Error(folly::stringPrintf("%s not found", key)) . would be better ?
There was a problem hiding this comment.
It will hurt the performance because miss cache is normal in practice.
|
Unit testing passed. |
|
Unit testing passed. |
|
Unit testing passed. |
* Add ConcurrentLRUCache * Address sky's comments * update mod * Add evict for specified key * Remove dependency on time obj
No description provided.