Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Considering improve Error Info on Fixed String Length exceeded #2462

Closed
wey-gu opened this issue Mar 25, 2021 · 1 comment
Closed

Considering improve Error Info on Fixed String Length exceeded #2462

wey-gu opened this issue Mar 25, 2021 · 1 comment
Labels
type/enhancement Type: make the code neat or more efficient

Comments

@wey-gu
Copy link
Contributor

wey-gu commented Mar 25, 2021

For a fresh NG user, when he/she created the very first space and tag and was about to import/insert data. In big chance, the error on VID string exceeded the default max length 8 could be hit, while, the error message is a little bit confusing, as it only refers to the information on only accept int 64 or fixed-length string, where, it's hard to infer on a too short default fixed string length was configured(as the default value).

The expected design will be good to either has information around the actual type of vid(int64 or string with length info) or provide hints on the length limit that was hit. Or, other solutions which could help with this 😁.

Thanks!

@wey-gu wey-gu changed the title Considering improve Error Info on Fixed String Length Considering improve Error Info on Fixed String Length exceeded Mar 25, 2021
@jude-zhu jude-zhu added the type/enhancement Type: make the code neat or more efficient label Apr 13, 2021
@Shylock-Hg
Copy link
Contributor

Had fixed in vesoft-inc/nebula-graph#776

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement Type: make the code neat or more efficient
Projects
None yet
Development

No branches or pull requests

3 participants