Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unreleased feature exposed #2617

Closed
randomJoe211 opened this issue Aug 19, 2021 · 4 comments
Closed

Unreleased feature exposed #2617

randomJoe211 opened this issue Aug 19, 2021 · 4 comments
Assignees
Labels
type/bug Type: something is unexpected
Milestone

Comments

@randomJoe211
Copy link
Contributor

Nebula Graph version: v2.5.0

Is it OK that parameters related to unreleased features are returned? For example in the result of SHOW CREATE SPACE basketballplayer, atomic_edge and ON default are displayed, but the corresponding features are not ready and not release in any Nebula Graph version.

Shouldn't there be rules to regulate such cases?

nebula) [basketballplayer]> SHOW CREATE SPACE basketballplayer;
+--------------------+-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| Space              | Create Space                                                                                                                                                                |
+--------------------+-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| "basketballplayer" | "CREATE SPACE `basketballplayer` (partition_num = 10, replica_factor = 1, charset = utf8, collate = utf8_bin, vid_type = FIXED_STRING(32), atomic_edge = false) ON default" |
+--------------------+-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------+

Users won't know what theses parameters are here for unless they dig into the source code. This kind of experience is really not good.

@randomJoe211
Copy link
Contributor Author

Same thing happened when running DESCRIBE SPACE basketballplayer:

[basketballplayer]> DESCRIBE SPACE basketballplayer;
+----+--------------------+------------------+----------------+---------+------------+--------------------+-------------+-----------+---------+
| ID | Name               | Partition Number | Replica Factor | Charset | Collate    | Vid Type           | Atomic Edge | Group     | Comment |
+----+--------------------+------------------+----------------+---------+------------+--------------------+-------------+-----------+---------+
| 1  | "basketballplayer" | 10               | 1              | "utf8"  | "utf8_bin" | "FIXED_STRING(32)" | false       | "default" |         |
+----+--------------------+------------------+----------------+---------+------------+--------------------+-------------+-----------+---------+
Got 1 rows (time spent 605/1097 us)

@CPWstatic CPWstatic transferred this issue from vesoft-inc/nebula-graph Aug 27, 2021
@CPWstatic CPWstatic added the type/question Type: question about the product label Aug 28, 2021
@Sophie-Xie Sophie-Xie added this to the v2.6.0 milestone Aug 31, 2021
@Sophie-Xie Sophie-Xie added type/bug Type: something is unexpected and removed type/question Type: question about the product labels Aug 31, 2021
@Sophie-Xie
Copy link
Contributor

pls close it after ZONE and TOSS release.

@critical27
Copy link
Contributor

The atomice_edge will be removed in 9.30, use a global gflag experimental instead.

@critical27 critical27 mentioned this issue Sep 1, 2021
@liuyu85cn
Copy link
Contributor

both merged. close this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Type: something is unexpected
Projects
None yet
Development

No branches or pull requests

6 participants