Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement of storage side profile implementation #2961

Closed
yixinglu opened this issue Sep 28, 2021 · 0 comments · Fixed by #2970
Closed

Enhancement of storage side profile implementation #2961

yixinglu opened this issue Sep 28, 2021 · 0 comments · Fixed by #2970
Assignees
Labels
type/enhancement Type: make the code neat or more efficient
Milestone

Comments

@yixinglu
Copy link
Contributor

yixinglu commented Sep 28, 2021

at preset, storage side use a gflag profile_storage_detail to control the profiling detail information collection rather than by the parameter of RPC called by graphd.

this feature is introduced in #2754

related issues #2599

there will be following issues:

  • PROFILE query of graphd could not response storage side profiling info if the above flag is false;
  • NON-Profile query of graphd also trigger the profiling in storaged if the above flag is true.

sollution

Add profile parameter in storage interfaces, it is up to graphd to decide whether the storaged needs to profile.

@yixinglu yixinglu added the type/feature req Type: feature request label Sep 28, 2021
@yixinglu yixinglu added the type/enhancement Type: make the code neat or more efficient label Sep 28, 2021
@Sophie-Xie Sophie-Xie added this to the v2.6.0 milestone Sep 28, 2021
@Sophie-Xie Sophie-Xie added this to To Do in Nebula Graph Core v2.6.0 via automation Sep 28, 2021
@Sophie-Xie Sophie-Xie moved this from To Do to Coding in Nebula Graph Core v2.6.0 Sep 28, 2021
@yixinglu yixinglu linked a pull request Sep 29, 2021 that will close this issue
Nebula Graph Core v2.6.0 automation moved this from Coding to Done Sep 29, 2021
@Sophie-Xie Sophie-Xie added type/enhancement Type: make the code neat or more efficient and removed type/enhancement Type: make the code neat or more efficient type/feature req Type: feature request labels Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement Type: make the code neat or more efficient
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

4 participants