Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server check version with server #3035

Closed
HarrisChu opened this issue Oct 11, 2021 · 3 comments
Closed

server check version with server #3035

HarrisChu opened this issue Oct 11, 2021 · 3 comments
Assignees
Labels
type/feature req Type: feature request

Comments

@HarrisChu
Copy link
Contributor

#2596

  1. assume v2.5.1 is in v2.6.0 white list.

and then

  1. SDK in v2.5.1 could call v2.6.0 server.
  2. graphd in v2.5.1 could also call v2.6.0 metad, as v2.5.1 is in v2.6.0 white list.

for point 2, it's an unreasonable, as graphd, storaged, metad versions should keep consistent.

@HarrisChu HarrisChu added type/bug Type: something is unexpected type/feature req Type: feature request and removed type/bug Type: something is unexpected labels Oct 11, 2021
@Shylock-Hg
Copy link
Contributor

This feature only check client/server compatibility not server/server.

@HarrisChu
Copy link
Contributor Author

This feature only check client/server compatibility not server/server.

yes, but we implement it in thrift interface, and the behavior is same in server/server side.

@Sophie-Xie Sophie-Xie added this to the v3.0.0 milestone Oct 18, 2021
@CPWstatic
Copy link
Contributor

As we talked about this offline, the meta-graph/storage should not always keep the same version since we have a rolling upgrade requirement. So we just close this issue first and keep the status quo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature req Type: feature request
Projects
None yet
Development

No branches or pull requests

4 participants