Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edge default datetime prop mismatch #3045

Closed
kikimo opened this issue Oct 13, 2021 · 6 comments
Closed

Edge default datetime prop mismatch #3045

kikimo opened this issue Oct 13, 2021 · 6 comments
Assignees
Labels
type/bug Type: something is unexpected
Milestone

Comments

@kikimo
Copy link
Contributor

kikimo commented Oct 13, 2021

Please check the FAQ documentation before raising an issue

Please check the FAQ documentation and old issues before raising an issue in case someone has asked the same question that you are asking.

Describe the bug (must be provided)

Edge default datetime prop mismatch.

Your Environments (must be provided)

  • OS: uname -a
  • Compliler: g++ --version or clang++ --version
  • CPU: lscpu
  • Commit id 030e5a9 (it's a branch containing all v2.6 commits, and @liuyu85cn is fixing TOSS problem there, but the mismatch has nothing to do with TOSS).

How To Reproduce(must be provided)

Steps to reproduce the behavior:

  1. start a nebula cluster
  2. create edge known(ts datetime default datetime(), idx string);
  3. start a client and insert 4096 edges without specifying ts field

check equality of kdata field of in/out edge, you will find a lot of edge prop mismatch, the discrepancy generally come form Microsec field of ts value, eg.

...
prop mismatch in edge 123->57, forward vs backward, idx: 333->15801 == 333->15801, ts: DateTime({Year:2021 Month:10 Day:13 Hour:1 Minute:56 Sec:21 Microsec:710000}) != DateTime({Year:2021 Month:10 Day:13 Hour:1 Minute:56 Sec:21 Microsec:709000})
prop mismatch in edge 105->68, forward vs backward, idx: 615->13508 == 615->13508, ts: DateTime({Year:2021 Month:10 Day:13 Hour:1 Minute:55 Sec:18 Microsec:680000}) != DateTime({Year:2021 Month:10 Day:13 Hour:1 Minute:55 Sec:18 Microsec:675000})
prop mismatch in edge 22->81, forward vs backward, idx: 547->2897 == 547->2897, ts: DateTime({Year:2021 Month:10 Day:13 Hour:1 Minute:53 Sec:4 Microsec:963000}) != DateTime({Year:2021 Month:10 Day:13 Hour:1 Minute:53 Sec:4 Microsec:920000})
...

Expected behavior

We expect the value of ts field to be equal in in/out edge of an edge.

Additional context

Provide logs and configs, or any other context to trace the problem.

@kikimo kikimo added the type/bug Type: something is unexpected label Oct 13, 2021
@kikimo kikimo added this to the v2.6.0 milestone Oct 13, 2021
@kikimo kikimo assigned critical27 and liuyu85cn and unassigned critical27 Oct 13, 2021
@HarrisChu
Copy link
Contributor

@czpmango cc

@critical27 critical27 modified the milestones: v2.6.0, v3.0.0 Oct 19, 2021
@liuyu85cn
Copy link
Contributor

This happened while instead of use the default GraphStorageClient, kiki called storage server API directly.
(for performance testing)
The AddEdgesRequest passed to storage has 1 propName and 2 vals.

Normally, when we used storageClient,
it will either

  1. leave propName empty
  2. make sure propName has the same size of prop vals.

This won't happen in user case. move to 3.0 to dig more.

@kikimo
Copy link
Contributor Author

kikimo commented Oct 23, 2021

This happened while instead of use the default GraphStorageClient, kiki called storage server API directly. (for performance testing) The AddEdgesRequest passed to storage has 1 propName and 2 vals.

Normally, when we used storageClient, it will either

  1. leave propName empty
  2. make sure propName has the same size of prop vals.

This won't happen in user case. move to 3.0 to dig more.

We still see a very little of datetime mismatch after we adjust the stresser, maybe there are unknown problems.

@critical27
Copy link
Contributor

Is this issue fixed?

@kikimo
Copy link
Contributor Author

kikimo commented Dec 28, 2021

Is this issue fixed?

not yet

@critical27 critical27 removed this from the v3.0.0 milestone Jan 21, 2022
@Sophie-Xie Sophie-Xie added this to the v3.1.0 milestone Jan 24, 2022
@critical27
Copy link
Contributor

Fixed in #3880

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Type: something is unexpected
Projects
None yet
Development

No branches or pull requests

5 participants