Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BaseProcess doPut shouldn't call onfinish. #3508

Closed
jackwener opened this issue Dec 20, 2021 · 1 comment
Closed

BaseProcess doPut shouldn't call onfinish. #3508

jackwener opened this issue Dec 20, 2021 · 1 comment
Assignees
Labels
type/enhancement Type: make the code neat or more efficient

Comments

@jackwener
Copy link
Contributor

jackwener commented Dec 20, 2021

Introduction

https://github.com/jackwener/nebula/blob/ef73a368aa059803d7c79e6846ec1d3306bff7b4/src/meta/processors/BaseProcessor-inl.h#L25

it should separate the onFinish in doPut, onFinish should be in the Process(), like:

doPut();
onFinish();

instead of

doPut(); // onFinish in it

Contents

Related work

@jackwener jackwener added the type/enhancement Type: make the code neat or more efficient label Dec 20, 2021
@jackwener jackwener self-assigned this Dec 20, 2021
@jackwener
Copy link
Contributor Author

@yixinglu What do you think of this problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement Type: make the code neat or more efficient
Projects
None yet
Development

No branches or pull requests

1 participant