Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor KVStore related #3517

Open
wenhaocs opened this issue Dec 21, 2021 · 0 comments
Open

Refactor KVStore related #3517

wenhaocs opened this issue Dec 21, 2021 · 0 comments
Labels
type/enhancement Type: make the code neat or more efficient

Comments

@wenhaocs
Copy link
Contributor

Introduction

We need to prepare for stores other than NebulaStore, e.g., cloud storage. In this case, NebulaStore can be some kind of KVStore with Raft. KVStore should be the general interface. However, the current KVStore has some logic related to Raft. In addition, NebulaStore inherit both KVStore and Handler, and has its own member function as well, which is not clear. What we want to achieve is
(1) A generic KVStore, which supports both cloud and premise underlying storage.
(2) NebulaStore is a member of CachedKVStore, which implements something else, e.g., RaftKVStore.
(3) All up layers in storage call KVStore interface

@wenhaocs wenhaocs added the type/enhancement Type: make the code neat or more efficient label Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement Type: make the code neat or more efficient
Projects
None yet
Development

No branches or pull requests

1 participant