Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

we should change thrift version in master branch #3543

Closed
HarrisChu opened this issue Dec 23, 2021 · 2 comments
Closed

we should change thrift version in master branch #3543

HarrisChu opened this issue Dec 23, 2021 · 2 comments
Assignees
@CPWstatic
Labels
type/bug Type: something is unexpected

Comments

@HarrisChu
Copy link
Contributor

currently, the version in common.thrift is still 2.6.0, and we update the client, e.g. nebula-go, nebula-console.
It will make user confused if he download the latest nebula-import to connect nebula v2.6.0.
https://discuss.nebula-graph.com.cn/t/topic/7006/9

we should update the version, and then when using the latest client, it would raise an incompatible error.
@HarrisChu HarrisChu added the type/bug Type: something is unexpected label Dec 23, 2021
@Sophie-Xie Sophie-Xie added this to the v3.0.0 milestone Dec 23, 2021
@jamieliu1023 jamieliu1023 mentioned this issue Dec 25, 2021
Closed
@HarrisChu
Copy link
Contributor Author

as talked offline, won't change the version util release.

@Sophie-Xie Sophie-Xie removed this from the v3.0.0 milestone Dec 30, 2021
@wey-gu
Copy link
Contributor

wey-gu commented Dec 30, 2021

Could we always mark version info in master as something different from the last tag/release to remove the confusion, this applies to all repo including studio, clients, other utils.

@jamieliu1023 jamieliu1023 mentioned this issue Jan 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CPWstatic CPWstatic

Labels
type/bug Type: something is unexpected
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@wey-gu @HarrisChu @CPWstatic @Sophie-Xie