Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should not create space if the host doesn't send heartbeat. #3578

Closed
HarrisChu opened this issue Dec 28, 2021 · 1 comment
Closed

should not create space if the host doesn't send heartbeat. #3578

HarrisChu opened this issue Dec 28, 2021 · 1 comment
Assignees
Labels
type/bug Type: something is unexpected
Milestone

Comments

@HarrisChu
Copy link
Contributor

as we can add some host that is not launched, when create space, we should verify if the hosts sent heartbeat.
otherwise the partitions would be in a wrong host.

# invalid host
(root@nebula) [(none)]> add hosts 192.168.8.66:9779
Execution succeeded (time spent 17185/20540 us)

(root@nebula) [(none)]> show zones
+----------------------------------+----------------+------+
| Name                             | Host           | Port |
+----------------------------------+----------------+------+
| "default_zone_192.168.8.63_9779" | "192.168.8.63" | 9779 |
| "default_zone_192.168.8.66_9779" | "192.168.8.66" | 9779 |
+----------------------------------+----------------+------+
Got 2 rows (time spent 1326/5641 us)

(root@nebula) [(none)]> show hosts
+----------------+------+-----------+--------------+----------------------+------------------------+
| Host           | Port | Status    | Leader count | Leader distribution  | Partition distribution |
+----------------+------+-----------+--------------+----------------------+------------------------+
| "192.168.8.63" | 9779 | "OFFLINE" | 0            | "No valid partition" | "s1:100"               |
| "Total"        |      |           | 0            |                      | "s1:100"               |
+----------------+------+-----------+--------------+----------------------+------------------------+
Got 2 rows (time spent 1460/10235 us)

(root@nebula) [(none)]> create space s2(vid_type=int, replica_factor=2)
Execution succeeded (time spent 22659/27157 us)

Tue, 28 Dec 2021 16:01:47 CST
  1. offline storage cannot be a valid engine.
  2. storage doesn't send heartbeat should not be a valid engine.
@HarrisChu HarrisChu added the type/bug Type: something is unexpected label Dec 28, 2021
@Sophie-Xie Sophie-Xie added this to the v3.0.0 milestone Dec 28, 2021
@HarrisChu
Copy link
Contributor Author

#3583

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Type: something is unexpected
Projects
None yet
Development

No branches or pull requests

3 participants