Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TCK framework is confusing #3638

Closed
zhaohaifei opened this issue Jan 5, 2022 · 2 comments
Closed

TCK framework is confusing #3638

zhaohaifei opened this issue Jan 5, 2022 · 2 comments
Labels
type/enhancement Type: make the code neat or more efficient

Comments

@zhaohaifei
Copy link
Contributor

zhaohaifei commented Jan 5, 2022

Introduction
The TCK framework is confusing:

  1. The entire framework is divided into test and tck, but a lot of content in test can be implemented using tck.
  2. Some methods are not abstract enough, such as NebulaService.start(), in which not only starts the nebula service, but also executes "add hosts".
  3. Many global variables are distributed in various files, with different names, but the content is the same. For example, CURR_PATH in nebula-test-run.py, CURR_DIR and TEST_DIR in makefile.
  4. Some variables are confusing, such as NB_TMP_PATH and SPACE_TMP_PATH, which seems directory names, but are actually file names.

In short, TCK is not good enough. It's better to make some changes.

Contents

Related work

@zhaohaifei zhaohaifei added the type/enhancement Type: make the code neat or more efficient label Jan 5, 2022
@HarrisChu
Copy link
Contributor

  1. too many steps in a file, we could separate the steps, e.g.
    define pytest_plugins in conftest.py, and then separate the steps
    image

image

@Sophie-Xie
Copy link
Contributor

Will be fixed in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement Type: make the code neat or more efficient
Projects
None yet
Development

No branches or pull requests

3 participants