Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

delete MetaHttpReplaceHostHandler after br release ? #3725

Closed
HarrisChu opened this issue Jan 14, 2022 · 1 comment
Closed

delete MetaHttpReplaceHostHandler after br release ? #3725

HarrisChu opened this issue Jan 14, 2022 · 1 comment
Assignees
@pengweisong
Labels
type/enhancement Type: make the code neat or more efficient
Milestone
v3.1.0

Comments

@HarrisChu
Copy link
Contributor

as we add zone and add hosts, MetaHttpReplaceHostHandler has no effort at all.
shall we remove it?
@HarrisChu HarrisChu added type/enhancement Type: make the code neat or more efficient type/bug Type: something is unexpected labels Jan 14, 2022
@Shylock-Hg Shylock-Hg removed the type/bug Type: something is unexpected label Jan 14, 2022
@jamieliu1023 jamieliu1023 mentioned this issue Jan 15, 2022
Closed
@jackwener jackwener self-assigned this Jan 19, 2022
@critical27
Copy link
Contributor

Talked with @pengweisong offline, there is already a interfaces which handle hosts correctly, will reuse it later

@pengweisong pengweisong self-assigned this Jan 24, 2022
@jackwener jackwener removed their assignment Jan 24, 2022
@pengweisong pengweisong mentioned this issue Jan 24, 2022
Merged
11 tasks
@Sophie-Xie Sophie-Xie added this to the v3.1.0 milestone Jan 27, 2022
@jamieliu1023 jamieliu1023 mentioned this issue Feb 5, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pengweisong pengweisong

Labels
type/enhancement Type: make the code neat or more efficient
Projects
No open projects
Nebula Graph v3.1.0
Status: Done
Milestone
v3.1.0
Development

No branches or pull requests
6 participants
@HarrisChu @critical27 @jackwener @Shylock-Hg @Sophie-Xie @pengweisong