Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor db_upgrader, more meaningful for dst_db_path parameter #3851

Closed
HarrisChu opened this issue Feb 7, 2022 · 1 comment
Closed

refactor db_upgrader, more meaningful for dst_db_path parameter #3851

HarrisChu opened this issue Feb 7, 2022 · 1 comment
Labels
priority/low-pri Priority: low type/enhancement Type: make the code neat or more efficient

Comments

@HarrisChu
Copy link
Contributor

HarrisChu commented Feb 7, 2022

in db_upgrader, when we upgrade from v1 to v2:

  1. read from src_db_path, and then write to dst_db_path

but when we upgrade from v2 to v3:

  1. rewrite to src_db_path directly.
  2. dst_db_path is useless.

so, there're some issues:

  1. dst_db_path would do nothing, but still copy wal to dst, so need to create a directory.
  2. won't copy data to dst_db_path, a little confused.
  3. there is no effective for --compactions parameter.
@HarrisChu HarrisChu added the type/enhancement Type: make the code neat or more efficient label Feb 7, 2022
@MuYiYong MuYiYong added the priority/med-pri Priority: medium label Apr 7, 2022
@MuYiYong MuYiYong added this to the v3.2.0 milestone Apr 8, 2022
@HarrisChu
Copy link
Contributor Author

BTW, could we make the checkpoint automatically?
and then no need for users to backup the original data manually.

cc @randomJoe211

@Sophie-Xie Sophie-Xie added priority/low-pri Priority: low and removed priority/med-pri Priority: medium labels May 26, 2022
@MuYiYong MuYiYong modified the milestones: v3.2.0, v3.3.0 Jun 15, 2022
@Sophie-Xie Sophie-Xie removed this from the v3.3.0 milestone Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/low-pri Priority: low type/enhancement Type: make the code neat or more efficient
Projects
None yet
Development

No branches or pull requests

4 participants