Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cypher] parser havenot surpportted insensitive upper/lower letters #4501

Open
abasi20 opened this issue Aug 9, 2022 · 1 comment
Open
Labels
type/feature req Type: feature request

Comments

@abasi20
Copy link

abasi20 commented Aug 9, 2022

your scanner is case-insensitive, so many key word have been know as upper case:eg . func as FUNC;

to reference the sql definiton , the mathric fountion : floor(1.4) must been know as floor(1.5) rather FLOOR(1.5)

your code definition:
"MATCH" { return TokenType::KW_MATCH; }

@abasi20 abasi20 added the type/feature req Type: feature request label Aug 9, 2022
@abasi20 abasi20 changed the title [cypher] parser doesnot surpport [cypher] parser havenot surpportted insensitive upper/lower letters Aug 9, 2022
@wey-gu
Copy link
Contributor

wey-gu commented Aug 10, 2022

Dear @abasi20 ,

Good catch, NebulaGraph is keyword/function case-insensitive by design, so we cannot escape keyword with case-change, instead, we could do it with `

For instance, both floor and FLOOR are valid functions, and to escape floor like:

CREATE EDGE located_in_building(`floor` int);

https://docs.nebula-graph.com.cn/3.2.0/3.ngql-guide/1.nGQL-overview/identifier-case-sensitivity/#_4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature req Type: feature request
Projects
None yet
Development

No branches or pull requests

2 participants