graph should not eat the storaged‘s error code？

[Nicole00]

General Question

When storaged happens leader change error, storaged return E_LEADER_CHANGED. When graphd get storaged's E_LEADER_CHANGED, it return E_EXECUTION_ERROR with message Storage Error: The leader has changed. Try again later..
should graphd return E_LEADER_CHANGED error code too?

[HarrisChu]

prefer a new error code in graphd, graphd should never return error code from storaged.

[xtcyclist]

To the graphd and to the user, errors from the storaged like this happen in the execution phase. It is indeed an execution error. Nothing wrong here. And, we shall not simply pass storaged's internal errors to the users, considering that graphd is the upper-most layer.

In 5.0, we will have a new system of reporting errors.