Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop space and the folder was removed but the disk space was not released #5157

Closed
pengweisong opened this issue Dec 29, 2022 · 4 comments
Closed
Assignees
Labels
affects/none PR/issue: this bug affects none version. need info Solution: need more information (ex. can't reproduce) process/fixed Process of bug severity/none Severity of bug type/bug Type: something is unexpected
Milestone

Comments

@pengweisong
Copy link
Contributor

Please check the FAQ documentation before raising an issue

Describe the bug (required)

https://discuss.nebula-graph.com.cn/t/topic/11776/5
When the space was dropped, the space directory was removed successfully, but the spaces used by sst was not released successfully.

Your Environments (required)

  • OS: uname -a
  • Compiler: g++ --version or clang++ --version
  • CPU: lscpu
  • Commit id (e.g. a3ffc7d8) 3.2

How To Reproduce(required)

Steps to reproduce the behavior:

The reason has not been located, guess it may have sth to do with the compaction:

  1. insert lot of data
  2. submit a compact job
  3. drop the space

Expected behavior

The space is released successfully.

Additional context

@pengweisong pengweisong added the type/bug Type: something is unexpected label Dec 29, 2022
@github-actions github-actions bot added affects/none PR/issue: this bug affects none version. severity/none Severity of bug labels Dec 29, 2022
@pengweisong pengweisong changed the title Drop space and the folder was removed but the space was not release Drop space and the folder was removed but the disk space was not released Dec 29, 2022
@HarrisChu
Copy link
Contributor

interesting..
do we rocksdb::CancelAllBackgroundWork when we remove the space?

@pengweisong
Copy link
Contributor Author

interesting.. do we rocksdb::CancelAllBackgroundWork when we remove the space?

RocksEngine::stop() has called it, but we did not call stop when drop space.. I'll add it.

What's more, we may should call rocksdb::Close() when deconstruct the RocksEngine.

@HarrisChu
Copy link
Contributor

could not reproduce

@Sophie-Xie Sophie-Xie added the need info Solution: need more information (ex. can't reproduce) label Jan 4, 2023
@Sophie-Xie
Copy link
Contributor

Close it first, reopen if it reappears.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects/none PR/issue: this bug affects none version. need info Solution: need more information (ex. can't reproduce) process/fixed Process of bug severity/none Severity of bug type/bug Type: something is unexpected
Projects
None yet
Development

No branches or pull requests

3 participants