Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable scan data directly #5170

Open
Shylock-Hg opened this issue Dec 30, 2022 · 1 comment
Open

Enable scan data directly #5170

Shylock-Hg opened this issue Dec 30, 2022 · 1 comment
Assignees
@Shylock-Hg
Labels
type/enhancement Type: make the code neat or more efficient

Comments

@Shylock-Hg
Copy link
Contributor

Shylock-Hg commented Dec 30, 2022 •
edited
Loading

Introduction

After #5082 , we could avoid OOM caused by scanning all data. So remove the limit number checking of ScanVertices and ScanEdges.

Contents

Related work
@Shylock-Hg Shylock-Hg added the type/enhancement Type: make the code neat or more efficient label Dec 30, 2022
@Shylock-Hg Shylock-Hg mentioned this issue Dec 30, 2022
Merged
11 tasks
@wey-gu wey-gu mentioned this issue Dec 31, 2022
Closed
@czpmango
Copy link
Contributor

Good catch!
At present, the implementation of statements like MATCH (v) RETURN v relies on the optimizer and brings too many problems. It is nothing special and we really should unify the implementation of all patterns(eg. we should let the optimizer decide whether to generate full scan nodes).

@czpmango czpmango mentioned this issue Jan 31, 2023
Open
@Shylock-Hg Shylock-Hg self-assigned this Mar 15, 2023
@Shylock-Hg Shylock-Hg mentioned this issue Mar 20, 2023
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Shylock-Hg Shylock-Hg

Labels
type/enhancement Type: make the code neat or more efficient
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@czpmango @Shylock-Hg