Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mixed usage of ngql and cypher statements #5182

Closed
jievince opened this issue Jan 3, 2023 · 1 comment · Fixed by #5183
Closed

Mixed usage of ngql and cypher statements #5182

jievince opened this issue Jan 3, 2023 · 1 comment · Fixed by #5183
Labels
affects/none PR/issue: this bug affects none version. process/done Process of bug severity/none Severity of bug type/bug Type: something is unexpected
Milestone

Comments

@jievince
Copy link
Contributor

jievince commented Jan 3, 2023

Please check the FAQ documentation before raising an issue

Describe the bug (required)

#3506 forbids the mixed usage of ngql and cypher statements, but it forgets to handle the standalone return statement.
See the following example:

go from "Tony Parker" over like yield id($$) as vid | return $-.vid

This query should report a syntax error according to our previous design, but in fact, this query can be executed successfully before because a standalone return statement is treated as a YieldSentence in our implementation. So a standalone statement is actually a ngql statement not a cypher statement in our implementation. This strange implementation causes a bug #5113.

Pr #5116 forbids the mixed usage of ngql and return statement, but it causes incompatibility issues. After a discussion with @MuYiYong @HarrisChu , we decided to be consistent with previous behaviors.

Your Environments (required)

  • OS: uname -a
  • Compiler: g++ --version or clang++ --version
  • CPU: lscpu
  • Commit id (e.g. a3ffc7d8)

How To Reproduce(required)

Steps to reproduce the behavior:

  1. Step 1
  2. Step 2
  3. Step 3

Expected behavior

Additional context

@jievince jievince added the type/bug Type: something is unexpected label Jan 3, 2023
@github-actions github-actions bot added affects/none PR/issue: this bug affects none version. severity/none Severity of bug labels Jan 3, 2023
@jievince jievince mentioned this issue Jan 3, 2023
11 tasks
@Sophie-Xie Sophie-Xie added this to the v3.4.0 milestone Jan 3, 2023
@github-actions github-actions bot added the process/fixed Process of bug label Jan 3, 2023
@HarrisChu HarrisChu reopened this Jan 4, 2023
@github-actions github-actions bot removed the process/fixed Process of bug label Jan 4, 2023
@xtcyclist
Copy link
Contributor

Close, since an conclusion has been reached.

@github-actions github-actions bot added the process/fixed Process of bug label Jan 12, 2023
@Hester-Gu Hester-Gu added the process/done Process of bug label Jan 13, 2023
@github-actions github-actions bot removed the process/fixed Process of bug label Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects/none PR/issue: this bug affects none version. process/done Process of bug severity/none Severity of bug type/bug Type: something is unexpected
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants