Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

confused error messages of delete tag #5255

Closed
thewkgithub opened this issue Jan 13, 2023 · 2 comments
Closed

confused error messages of delete tag #5255

thewkgithub opened this issue Jan 13, 2023 · 2 comments

Comments

@thewkgithub
Copy link

Version: 3.3.0

对一个不存在的点, 删除Tag会报错. 返回: TagName `test1' is nonexistent
DELETE TAG test1 FROM 'v_not_exist';

对一个不存在的点, 删除所有Tag, 又不报错了...返回的errorCode: 0.
DELETE TAG * FROM 'v_not_exist';

@thewkgithub thewkgithub added the type/bug Type: something is unexpected label Jan 13, 2023
@github-actions github-actions bot added affects/none PR/issue: this bug affects none version. severity/none Severity of bug labels Jan 13, 2023
@Sophie-Xie Sophie-Xie changed the title 删除Tag的Bug. confused error messages of delete tag Feb 7, 2023
@Sophie-Xie Sophie-Xie added this to the v3.5.0 milestone Feb 7, 2023
@Milittle
Copy link
Contributor

Milittle commented Feb 13, 2023

I think this isn't bug, the first error meesage from graph's validator, but default if you do not exist this vertex, the storage won't raise some noise for us.
Just my humble opinion

@xtcyclist xtcyclist self-assigned this Feb 27, 2023
@xtcyclist xtcyclist added type/feature req Type: feature request and removed type/bug Type: something is unexpected severity/none Severity of bug affects/none PR/issue: this bug affects none version. labels Mar 28, 2023
@xtcyclist
Copy link
Contributor

xtcyclist commented Mar 28, 2023

Hi, this is not a bug, as explained by @Milittle. The first error was reported because tag test1 does not exist. It has nothing to do with whether the vertex exists or not.

If you want DELETE statements to report errors on vertices that do not exist, you are welcomed to start an issue of the type feature request. Thanks.

I close this 'bug' issue for now.

@xtcyclist xtcyclist removed their assignment Mar 28, 2023
@xtcyclist xtcyclist removed this from the v3.5.0 milestone Mar 28, 2023
@xtcyclist xtcyclist removed the type/feature req Type: feature request label Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants