Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefix performance get very bad after clear data #5524

Closed
luyade opened this issue Apr 23, 2023 · 2 comments
Closed

Prefix performance get very bad after clear data #5524

luyade opened this issue Apr 23, 2023 · 2 comments
Labels
type/enhancement Type: make the code neat or more efficient

Comments

@luyade
Copy link
Contributor

luyade commented Apr 23, 2023

Introduction

If we have a large amount of data in the backend rocksdb, the prefix performance will get extremely bad after the data is cleared, such as clear space or clear part before sending snapshot. And also this will impact the startup of storaged (see RocksEngine::allParts() implementation), which will even need several hours to finish the startup process.

Contents

Set iterate upper bound for read options of prefix operation. I did the testing, after the change, the performance will get almost normal as usual.

Related work

@luyade luyade added the type/enhancement Type: make the code neat or more efficient label Apr 23, 2023
@critical27
Copy link
Contributor

You'll set upper bound for each interface?

@critical27
Copy link
Contributor

BTW, a recent version of RocksDB has claimed to improve performance after DeleteRange, this is a big pitfalls before. But I haven't test it yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement Type: make the code neat or more efficient
Projects
None yet
Development

No branches or pull requests

2 participants