Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to text-video-search sample app #1416

Merged
merged 3 commits into from
Apr 17, 2024
Merged

Conversation

thomasht86
Copy link
Contributor

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

  • Added setuptools to requirements.
  • Fixed a bug in Application package name containing -
  • Updated a stale link to pyvespa docs.

Also, a bit of formatting diffs in the notebook, due to ruff.
Did not run through the whole sample app, as it downloads ~6GB and takes a lot of time, but these changes enable the first half of the notebook to run successfully at least.

@thomasht86 thomasht86 requested a review from kkraune April 17, 2024 08:49
Copy link
Member

@kkraune kkraune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants