Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support legacy global-service-id syntax combined with feature flag #13835

Merged
merged 3 commits into from Jul 8, 2020
Merged

Support legacy global-service-id syntax combined with feature flag #13835

merged 3 commits into from Jul 8, 2020

Conversation

mpolden
Copy link
Member

@mpolden mpolden commented Jul 8, 2020

hmusum
hmusum approved these changes Jul 8, 2020
View reviewed changes
Copy link
Member

@hmusum hmusum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mpolden mpolden merged commit acbc745 into master Jul 8, 2020
@mpolden mpolden deleted the mpolden/legacy-syntax branch July 8, 2020 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hmusum hmusum hmusum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mpolden @hmusum